Skip to content

Benchmark Improvements#75

Open
jeremyprime wants to merge 4 commits intomainfrom
benchmark-improvements
Open

Benchmark Improvements#75
jeremyprime wants to merge 4 commits intomainfrom
benchmark-improvements

Conversation

@jeremyprime
Copy link
Copy Markdown
Collaborator

@jeremyprime jeremyprime commented Mar 18, 2026

Changes:

  • Fixed GLIDE JDK requirement (needs JDK 11, otherwise will fallback to Gradle toolchain which calls Foojay Disco API, which frequently is not available causing CI to fail)
  • Added server topology mode option (standalone or cluster, defaults to standalone)

Note that I also tried to add 100-client workload, but it timed out after 30 minutes. Seems that resp-bench BenchmarkEngine.createClients creates a separate GLIDE client per connection, which works for other drivers including spring-data-valkey, but not for GLIDE itself when tested as the primary driver.

Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
@jeremyprime jeremyprime marked this pull request as ready for review March 18, 2026 20:40
@jeremyprime jeremyprime requested review from ikolomi and liorsve March 18, 2026 20:40
Signed-off-by: Jeremy Parr-Pearson <jeremy.parr-pearson@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant