revamped the connection layout and added the cluster grouping#68
Merged
nassery318 merged 4 commits intovalkey-io:mainfrom Nov 13, 2025
Merged
Conversation
| @@ -0,0 +1,111 @@ | |||
| import { useState, useRef, useEffect } from "react" | |||
| import { CONNECTED } from "@common/src/constants.ts" | |||
Collaborator
There was a problem hiding this comment.
won't this fail the linter because of the imports order? it should be below lucide-react
Contributor
Author
There was a problem hiding this comment.
This in not effecting the linter, but I still organized it in the new commit.
| const hasConnectedInstance = connections.some(({ connection }) => connection.status === CONNECTED) | ||
| const connectedCount = connections.filter(({ connection }) => connection.status === CONNECTED).length | ||
|
|
||
| const firstConnectedConnection = connections.find(({ connection }) => connection.status === CONNECTED) |
Collaborator
There was a problem hiding this comment.
while the impact is very minor, we can still iterate over connections only once
const connected = connections.filter(({ connection }) => connection.status === CONNECTED)
const connectedCount = connected.length
const hasConnectedInstance = connectedCount > 0
const firstConnectedConnection = connected[0]
Signed-off-by: nassery318 <nassery318@gmail.com>
| }>( | ||
| (acc, [connectionId, connection]) => { | ||
| const clusterId = connection.connectionDetails.clusterId | ||
| if (clusterId) { |
Collaborator
There was a problem hiding this comment.
maybe using nullish coalescing assignment operator can improve readbility here
if (clusterId)
(acc.clusterGroups[clusterId] ??= []).push({ connectionId, connection })
else
acc.standaloneConnections.push({ connectionId, connection })
Signed-off-by: nassery318 <nassery318@gmail.com>
arseny-kostenko
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.