Multi-database support in cluster mode #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated documentation to reflect multi-database support in Valkey Cluster. - Removed outdated restrictions on `SELECT` and database-related commands. - Clarified that `MIGRATE`, `COUNTKEYSINSLOT`, and `GETKEYSINSLOT` operate within the selected database. - Clarified that `SWAPDB` is disabled in cluster mode to prevent shard inconsistencies. Signed-off-by: xbasel <[email protected]>
|
Depends on valkey-io/valkey#1671 |
madolson
reviewed
May 6, 2025
commands/cluster-countkeysinslot.md
Outdated
Comment on lines
1
to
2
| Returns the number of keys in the specified Valkey Cluster hash slot **in the | ||
| currently selected database**. The command only queries the local data set, |
There was a problem hiding this comment.
I don't think we need to bold the new text. I would clarify than when the default is 1, it captures all of the keys in the slot.
There was a problem hiding this comment.
@madolson
Could you clarify what you mean by when the default is 1, it captures all of the keys in the slot?
commands/cluster-getkeysinslot.md
Outdated
Comment on lines
1
to
4
| The command returns an array of key names stored in the contacted node and | ||
| hashing to the specified hash slot **in the currently selected database**. | ||
| The maximum number of keys to return is specified via the `count` argument, | ||
| so that it is possible for the user of this API to batch-process keys. |
There was a problem hiding this comment.
Since you're here, can you clarify that batch processing only works if you are deleting the keys. If you are trying to scan the slot, you can't batch process it.
Also, I don't think we need to bold it's in the currently selected database.
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: xbasel <[email protected]>
Signed-off-by: xbasel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECTand database-related commands.MIGRATE,COUNTKEYSINSLOT, andGETKEYSINSLOToperate within the selected database.SWAPDBis disabled in cluster mode to prevent shard inconsistencies.