-
Notifications
You must be signed in to change notification settings - Fork 102
Replace redis-rb-cluster examples with official Valkey GLIDE client using original Ruby logic #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@copilot use valkey-glide nodejs https://github.com/valkey-io/valkey-glide/tree/main/node |
Updated the implementation to use the official Valkey GLIDE Node.js API from the specified repository. Fixed the client configuration structure, updated timeout settings, and added clientName parameter to match the official documentation examples. Commit: 8fd3fad |
…lot issues Co-authored-by: avifenesh <[email protected]>
The HTML files were already removed in a previous commit (8c0482a). The repository is now clean of any HTML test files. |
Co-authored-by: avifenesh <[email protected]>
Signed-off-by: Avi Fenesh <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]> Signed-off-by: Avi Fenesh <[email protected]>
topics/cluster-tutorial.md
Outdated
| * `MSET foo1 1 foo2 2 foo3 3 ... foo100 100` (batch of 100 keys) | ||
| * `MSET foo101 101 foo102 102 ... foo200 200` (next batch) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a follow up issue with @asafpamzn points
…low-up issue Co-authored-by: avifenesh <[email protected]>
Co-authored-by: avifenesh <[email protected]>
|
@copilot review and offer changes |
Co-authored-by: avifenesh <[email protected]>
Completed comprehensive review and made the following improvements: Changes Made (Commit 276cb24):
Code Review Summary: Current Code Quality:
The code example is production-ready and educational, demonstrating cluster operations while maintaining good JavaScript practices. |
|
@zuiderkwast @stockholmux @madolson should i merge? Close? |
Completed Review and Changes
addressesparameter (line 400)Summary
All Ruby references have been removed from the Node.js example. The code now:
The Valkey GLIDE Node.js example is now production-ready and provides clear educational value for cluster operations.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.