fix(tests): Fix flaky tests and add reusable test infrastructure#399
Open
currantw wants to merge 17 commits into
Open
fix(tests): Fix flaky tests and add reusable test infrastructure#399currantw wants to merge 17 commits into
currantw wants to merge 17 commits into
Conversation
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
alexr-bq
approved these changes
May 13, 2026
… into 94_flaky_test_TestKeyIdleTime
… into 94_flaky_test_TestKeyIdleTime
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
currantw
commented
May 14, 2026
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
Signed-off-by: currantw <taylor.curran@improving.com>
TestKeyIdleTime and add reusable Polling utility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestKeyIdleTimeUpdateConnectionPasswordTestsReadFromTests.ConfigurationPipeline_ClonePreservesReadFromConfigurationReadFromTests.ConfigurationPipeline_ValidationErrorPropagationPollingutility andServerFixturebase class.Issue Link
Features and Behaviour Changes
⚪ None — test infrastructure only.
Implementation
Pollingutility (tests/Valkey.Glide.TestUtils/Polling.cs): ProvidesAssertTrueandAssertTrueAsyncmethods that poll a condition with configurable timeout and interval, callingAssert.Failon timeout. Follows the same pattern previously used inPubSubUtils.ServerFixturebase class (tests/Valkey.Glide.TestUtils/Fixture.cs): Provides shared standalone/cluster servers,GetServer(bool),CreateClientAsync(bool), andIDisposablelifecycle for test fixtures that need isolated servers.TestKeyIdleTime: Replaced the fixed 1-secondTask.Delaywith a polling loop that retries for up to 10 seconds.UpdateConnectionPasswordTests: IntroducedUpdateConnectionPasswordFixture(extendsServerFixture) with aRetryStrategyfor cluster client creation to handle transient connection timeouts during cluster startup. Replaced[InlineData(true/false)]with[MemberData(nameof(ClusterMode), MemberType = typeof(Data))]. Servers are now shared via the fixture instead of created per-test.ReadFromTests: UseTestConfiguration.DefaultCompatibleConfig()instead of manualConfigurationOptionssetup inConfigurationPipeline_ValidationErrorPropagationandConfigurationPipeline_ClonePreservesReadFromConfiguration, ensuringResponseTimeoutis set to prevent timeouts in CI.PubSubUtils.AssertSubscribedAsync,PubSubUtils.AssertNotSubscribedAsync,PubSubQueueTests, andPubSubCommandTests.AssertHandlerReceivesto use the newPollingutility, reducing duplicated boilerplate.Limitations
⚪ None
Testing
✅ All tests pass (
dotnet buildwith zero warnings/errors).Related Issues
TestKeyIdleTime)UpdateConnectionPasswordcluster mode)Checklist
CHANGELOG.md,README.md,DEVELOPER.md, and other documentation files are updated.mainor releasemain, squash otherwise.