Open
Conversation
Signed-off-by: Edward Liang <edward.liang@improving.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci(php): add Docker-based CI for Valkey Search module testing
Summary
Adds a reusable GitHub Actions composite action (
start-valkey-docker) that spins up standalone, cluster, and auth-protected Valkey servers using Docker with the valkey-bundle image (which includes the Search module). Updates the CI workflows to use Docker containers for Valkey 9.0 on Ubuntu, falling back to native server startup for other versions/platforms.This is independent of the search command PRs and can be merged separately.
Issue link
Closes #165
Features / Behaviour Changes
.github/workflows/start-valkey-docker/action.ymlcomposite actionvalkey/valkey-bundle:9.1-rc1(pinned until stable 9.x images ship)valkey-serveris available on the hostvalkey-clifrom the image for cluster creation and health checksphp.ymlto use Docker for 9.0+ubuntu, native for everything elsetest-pecl-packageandtest-pie.ymlto use the new actionrun-php-testsImplementation
The action checks Docker availability first, then either pulls the bundle image and starts containers with
--network host, or falls back to the existing shell scripts. TLS setup always uses the hostvalkey-serverbinary (built from source byinstall-engine) since the Alpine binary from the Docker image may not work on Ubuntu.Limitations
valkey-bundle:9.1-rc1. Needs updating when stable 9.x images are published.valkey-serverbeing available on the host. So, these tests use the built-from-source server.Testing
Tested in CI across the matrix (Ubuntu + macOS, multiple engine versions, PHP 8.2/8.3). Docker path runs on Ubuntu with 9.0, native path runs everywhere else.
Checklist
Before submitting the PR make sure the following are checked: