PHP: fix memory leaks and resource management issues#174
Open
prateek-kumar-improving wants to merge 2 commits intomainfrom
Open
PHP: fix memory leaks and resource management issues#174prateek-kumar-improving wants to merge 2 commits intomainfrom
prateek-kumar-improving wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
f578918 to
826563e
Compare
jeremyprime
reviewed
Mar 27, 2026
| void free_valkey_glide_object(zend_object* object) { | ||
| valkey_glide_object* valkey_glide = VALKEY_GLIDE_PHP_GET_OBJECT(valkey_glide_object, object); | ||
|
|
||
| /* Free buffered batch commands if object is destroyed mid-batch */ |
There was a problem hiding this comment.
Should the buffered commands also be cleaned up when close is called? This could be moved to a helper function and called here and in close.
This also applies to valkey_glide_cluster.c file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple memory leaks, a potential crash in debug builds, and a resource management gap.
Issue link
This Pull Request is linked to issue (URL): #175
Features / Behaviour Changes
on garbage collection.
Implementation
Testing
All integration tests will run.
Checklist
Before submitting the PR make sure the following are checked: