Skip to content

Java: move BackoffStrategy configuration to BaseConfiguration + Added Jitter param #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025

Conversation

shohamazon
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@shohamazon shohamazon marked this pull request as ready for review May 8, 2025 11:01
@shohamazon shohamazon requested a review from a team as a code owner May 8, 2025 11:01
@@ -20,6 +20,7 @@
* .numOfRetries(5)
* .exponentBase(2)
* .factor(3)
* .jitterPercent(20)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix doc above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python

@@ -127,6 +127,8 @@ public class GlideClusterClient extends BaseClient
* <code>true</code>, the client will establish secure connections using TLS.
* <li><b>Pub/Sub Subscriptions</b>: Any channels or patterns specified in {@link
* ClusterSubscriptionConfiguration} will be subscribed to upon connection.
* <li><b>Reconnection Strategy</b>: The {@link BackoffStrategy} settings define how the
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think ab it

@GilboaAWS GilboaAWS changed the title Java: move BackoffStrategy configuration to BaseConfiguration Java: move BackoffStrategy configuration to BaseConfiguration + Added Jitter param May 22, 2025
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Shoham Elias <[email protected]>
Signed-off-by: Shoham Elias <[email protected]>
@shohamazon shohamazon force-pushed the java/backoff-strategy branch from 5ccf4e6 to 6548be1 Compare May 26, 2025 14:26
@shohamazon shohamazon merged commit 38c5bde into valkey-io:main May 27, 2025
19 checks passed
@shohamazon shohamazon deleted the java/backoff-strategy branch May 27, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants