Skip to content

Node: move BackoffStrategy configuration to BaseConfiguration + Added Jitter param #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

shohamazon
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@shohamazon shohamazon marked this pull request as ready for review May 11, 2025 07:39
@shohamazon shohamazon requested a review from a team as a code owner May 11, 2025 07:39
@GilboaAWS GilboaAWS self-requested a review May 22, 2025 09:02
* - `numberOfRetries`: The maximum number of retry attempts with increasing delays.
* - After this limit is reached, the retry interval becomes constant.
* - `factor`: A multiplier applied to the base delay between retries (e.g., `500` means a 500ms base delay).
* - `exponentBase`: The exponential growth factor for delays (e.g., `2` means the delay doubles with each retry).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jitter precent

@GilboaAWS GilboaAWS changed the title Node: move BackoffStrategy configuration to BaseConfiguration Node: move BackoffStrategy configuration to BaseConfiguration + Added Jitter param May 22, 2025
@shohamazon shohamazon merged commit aef2842 into valkey-io:main May 27, 2025
32 checks passed
@shohamazon shohamazon deleted the node/back-off branch May 27, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants