Skip to content

[WIP]C#: Add generic commands #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MikeMwita
Copy link
Collaborator

Issue link

This Pull Request is linked to issue (URL): [REPLACE ME]

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@MikeMwita MikeMwita requested a review from a team as a code owner May 8, 2025 21:45
@MikeMwita MikeMwita changed the title C#: Add generic commands [WIP]C#: Add generic commands May 8, 2025
@MikeMwita MikeMwita force-pushed the c-sharp-generic-commands branch from e277272 to 1a74a7e Compare May 8, 2025 21:49
@MikeMwita
Copy link
Collaborator Author

MikeMwita commented May 8, 2025

@Yury-Fridlyand, is there FFI support for generic commands atm, so I don't have to rely on CustomCommand & thus switch to FFI bindings.

@yipin-chen
Copy link
Collaborator

@Yury-Fridlyand, is there FFI support for generic commands atm, so I don't have to rely on CustomCommand & thus switch to FFI bindings.

Hi Mike,
Currently, we are busy working on 2.0 GA release, and Yury might be delayed in replying or reviewing your PR.
For C#, you can find our progress and implemented support in epic issue #216.

@Yury-Fridlyand
Copy link
Collaborator

Using binding generator is TBD. We can use csbindgen - it is pretty simple to use it, but some code changed are need to adopt it.
It produces unsafe code, I wanted to avoid this, that's the reason it is not done yet.

Please don't use custom command. So far I manually copied enum values for request type.

@Yury-Fridlyand Yury-Fridlyand added the C# C# wrapper label May 12, 2025
@yipin-chen yipin-chen requested a review from Yury-Fridlyand May 14, 2025 15:58
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request May 16, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C# wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants