Skip to content

[WIP]Go: Support Opentelemetry span #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented May 12, 2025

tests arent correct yet

Issue link

This Pull Request is linked to issue (URL): #3531

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner May 12, 2025 05:06
@tjzhang-BQ tjzhang-BQ added the go golang wrapper label May 12, 2025
@tjzhang-BQ tjzhang-BQ marked this pull request as draft May 12, 2025 05:07
@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review May 13, 2025 05:23
adarovadya and others added 6 commits May 14, 2025 11:09
* create ffi call to create and drop a span from node

* handle span transaction and pipeline

* Core/Node: add open telemetry config for metrics and traces

---------

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
* Rust: add OpenTelemetry metrics infra

* add timeout_error metric

* add metrics file exporter

Signed-off-by: Adar Ovadia <[email protected]>

---------

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
* change otel config to a static global object

* fix race in OTEL init

* fix comments + unit tests runs from one task

* Change to shared runtime

Signed-off-by: Adar Ovadia <[email protected]>

---------

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
Co-authored-by: barshaul <[email protected]>
* removed unessecery configs due moved to a global config

Signed-off-by: Adar Ovadia <[email protected]>

---------

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
…L config (#3830)

* Node: Create spans statistic only - according to samplePercentage OTEL config

Signed-off-by: Adar Ovadia <[email protected]>

---------

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
@adarovadya adarovadya force-pushed the opentelemetry-glide-2.0 branch from abe1c5c to cf192db Compare May 14, 2025 14:03
@yipin-chen yipin-chen requested a review from adarovadya May 16, 2025 16:01
Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
@adarovadya
Copy link
Collaborator

Please rebase the opentelemetry-glide-2.0 branch.
All the required core changes and node updates have been merged.

adarovadya and others added 2 commits May 20, 2025 10:53
use the exiting life time if exit

Signed-off-by: Adar Ovadia <[email protected]>
Co-authored-by: Adar Ovadia <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
@adarovadya adarovadya force-pushed the opentelemetry-glide-2.0 branch from 92262cc to dffcace Compare May 21, 2025 10:00
@adarovadya adarovadya deleted the branch opentelemetry-glide-2.0 May 21, 2025 10:34
@adarovadya adarovadya closed this May 21, 2025
@adarovadya
Copy link
Collaborator

please reopen and change the base branch to main

@adarovadya
Copy link
Collaborator

new PR #3932

@tjzhang-BQ tjzhang-BQ mentioned this pull request May 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants