-
Notifications
You must be signed in to change notification settings - Fork 90
[WIP]Go: Support Opentelemetry span #3834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create ffi call to create and drop a span from node * handle span transaction and pipeline * Core/Node: add open telemetry config for metrics and traces --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
* Rust: add OpenTelemetry metrics infra * add timeout_error metric * add metrics file exporter Signed-off-by: Adar Ovadia <[email protected]> --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
* change otel config to a static global object * fix race in OTEL init * fix comments + unit tests runs from one task * Change to shared runtime Signed-off-by: Adar Ovadia <[email protected]> --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]> Co-authored-by: barshaul <[email protected]>
* removed unessecery configs due moved to a global config Signed-off-by: Adar Ovadia <[email protected]> --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
…L config (#3830) * Node: Create spans statistic only - according to samplePercentage OTEL config Signed-off-by: Adar Ovadia <[email protected]> --------- Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
Signed-off-by: Adar Ovadia <[email protected]>
abe1c5c
to
cf192db
Compare
Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
Please rebase the |
use the exiting life time if exit Signed-off-by: Adar Ovadia <[email protected]> Co-authored-by: Adar Ovadia <[email protected]>
Signed-off-by: TJ Zhang <[email protected]>
92262cc
to
dffcace
Compare
please reopen and change the base branch to main |
new PR #3932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests arent correct yet
Issue link
This Pull Request is linked to issue (URL): #3531
Checklist
Before submitting the PR make sure the following are checked: