Skip to content

Go: Clean up most panics in FFI layer #3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 62 commits into from
Jun 2, 2025
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
dddfde0
Add ffi/src/lib.rs invoke_script function
prateek-kumar-improving Apr 14, 2025
114474a
Added invokeScript in base_client.go
prateek-kumar-improving Apr 15, 2025
2278b09
Added glide_cluster_client invokeScript methods
prateek-kumar-improving Apr 15, 2025
a95f7a2
Added glide_cluster_client invokeScript methods
prateek-kumar-improving Apr 15, 2025
8eaebdf
Remove file
prateek-kumar-improving Apr 15, 2025
9e2fb42
Fix response variable
prateek-kumar-improving Apr 15, 2025
b66e36c
Remove duplicate code
prateek-kumar-improving Apr 15, 2025
85dd636
Added test case and fixed review comments
prateek-kumar-improving Apr 17, 2025
b7e1424
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 17, 2025
8ef52f4
Go: update interfaces
prateek-kumar-improving Apr 17, 2025
50e4fb6
Go: update interfaces
prateek-kumar-improving Apr 17, 2025
1484990
Fix review comments
prateek-kumar-improving Apr 17, 2025
087f5c5
Fix review comments
prateek-kumar-improving Apr 17, 2025
d5bda7f
Fix review comments
prateek-kumar-improving Apr 17, 2025
552980c
Fix review comments
prateek-kumar-improving Apr 17, 2025
a4c87a5
Go: fix review comments
prateek-kumar-improving Apr 21, 2025
14f5b6b
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 21, 2025
a9af854
Go: Update test cases
prateek-kumar-improving Apr 21, 2025
d0aa6a8
Fix formatting issue
prateek-kumar-improving Apr 22, 2025
be9f67c
Add examples
prateek-kumar-improving Apr 22, 2025
97b48c7
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
25cdd3d
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
541fc83
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
dde7efc
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
40c0549
Go: Update changelog.md
prateek-kumar-improving Apr 22, 2025
e01bf51
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 22, 2025
a394ffa
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
e57d32c
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
1a5f0c3
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
9376615
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
ad5fffc
Go: Review comments updated
prateek-kumar-improving Apr 22, 2025
28d4153
Go: Review comments updated
prateek-kumar-improving Apr 23, 2025
4969fd2
Go: Review comments updated
prateek-kumar-improving Apr 23, 2025
a1cb443
Go: Review comments updated
prateek-kumar-improving Apr 23, 2025
b73cdcb
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 23, 2025
14a09cd
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 23, 2025
884e74f
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 23, 2025
38e6d36
Go/edlng script exists (#3649)
prateek-kumar-improving Apr 24, 2025
9f402ca
Merge branch 'main' into go/script-eval-load
prateek-kumar-improving Apr 24, 2025
f057092
Go: Add `SCRIPT KILL` (#3670)
edlng Apr 25, 2025
cc4e943
Go: Add script flush command (#3662)
prateek-kumar-improving Apr 25, 2025
9e756bf
Use `usize`.
Yury-Fridlyand Apr 25, 2025
c9e1ec7
Dont `unwrap`.
Yury-Fridlyand Apr 25, 2025
fa52062
Proper deref client ptr
Yury-Fridlyand Apr 25, 2025
38c8be6
Stop panicking in places where we should allow user to be able to rec…
jonathanl-bq May 16, 2025
2780fe8
Remove reference to type that no longer exists
jonathanl-bq May 16, 2025
26adb24
Return binary data instead of C string for store_script
jonathanl-bq May 20, 2025
9ad98ce
Avoid UB in store_script and drop_script
jonathanl-bq May 22, 2025
4b1d163
Set panic = abort for FFI layer panic runtime
jonathanl-bq May 22, 2025
af8949c
Address PR comments
jonathanl-bq May 25, 2025
56da7b2
Resolve merge conflicts
jonathanl-bq May 26, 2025
b5f3361
Address PR comments
jonathanl-bq May 26, 2025
6972635
Resolve merge conflicts
jonathanl-bq May 28, 2025
3d3d522
Remove merge conflict marker
jonathanl-bq May 28, 2025
611d336
Fix build errors
jonathanl-bq May 29, 2025
3f80672
Fix clippy lints
jonathanl-bq May 29, 2025
553a6f2
Fix compilation errors in ffi client tests
jonathanl-bq May 29, 2025
0fdc52c
Fix go vet issue
jonathanl-bq May 29, 2025
3066830
Fix formatting issues
jonathanl-bq May 29, 2025
225c097
Address most PR comments
jonathanl-bq May 31, 2025
23c1d1e
Fix formatting issues
jonathanl-bq Jun 2, 2025
9e67425
Fix docs and parameter naming for pubsub callback (request_id back to…
jonathanl-bq Jun 2, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ffi/Cargo.toml
Original file line number Diff line number Diff line change
@@ -24,3 +24,4 @@ opt-level = 3 # Optimize for performance
lto = "fat" # Enable the most aggressive Link Time Optimization
codegen-units = 1 # Reduce the number of code generation units, increasing optimization time but improving performance
strip = "symbols" # Remove symbol
panic = "abort" # Code size optimization and prevent unwinding across FFI boundaries
Loading

Unchanged files with check annotations Beta

This software includes external packages and source code.
The applicable license information is listed below:
This software includes external packages and source code.
The applicable license information is listed below:
This software includes external packages and source code.
The applicable license information is listed below:
This software includes external packages and source code.
The applicable license information is listed below: