Go: Enable Testing with RC #3916
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml | ||
| index d83c6f577..6eb9046ba 100644 | ||
| --- a/.github/workflows/go.yml | ||
| +++ b/.github/workflows/go.yml | ||
| @@ -137,8 +137,8 @@ jobs: | ||
| - name: Install & build & test | ||
| working-directory: go | ||
| run: | | ||
| - make install-tools build | ||
| - make -k unit-test integ-test | ||
|
There was a problem hiding this comment. Why are we not running unit-tests? There was a problem hiding this comment. If I remember the exact error correctly, it was because I ran into errors like this /usr/local/Cellar/go/1.24.3/libexec/pkg/tool/darwin_amd64/link: running cc failed: exit status 1
/usr/bin/cc -arch x86_64 -m64 -Wl,-S -Wl,-x -o $WORK/b243/integTest.test -Qunused-arguments /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/go.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000000.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000001.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000002.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000003.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000004.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000005.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000006.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000007.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000008.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000009.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000010.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000011.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000012.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000013.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000014.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000015.o /var/folders/c9/lnprlxdx4zlgfz2mkqtq2h4r0000gp/T/go-link-944871722/000016.o -lresolv -O2 -g -lglide_rs -lm -framework Security -O2 -g -O2 -g -lpthread -framework CoreFoundation -framework Security
ld: library 'glide_rs' not found
clang: error: linker command failed with exit code 1 (use -v to see invocation) |
||
| + make install-tools | ||
| + make -k integ-test | ||
| make -k pubsub-test | ||
| make -k opentelemetry-test | ||
|
|
||
| @@ -164,44 +164,6 @@ jobs: | ||
| benchmarks/results/** | ||
| go/reports/** | ||
|
|
||
| - lint: | ||
| - timeout-minutes: 10 | ||
| - runs-on: ubuntu-latest | ||
| - if: ${{ github.event.inputs.rc-test != 'true' }} | ||
| - steps: | ||
| - - uses: actions/checkout@v4 | ||
| - | ||
| - - name: Set up Go | ||
| - uses: actions/setup-go@v5 | ||
| - with: | ||
| - go-version: ${{ env.BASE_GO_VERSION }} | ||
| - cache-dependency-path: go/go.sum | ||
| - | ||
| - - name: Install protoc | ||
| - uses: ./.github/workflows/install-rust-and-protoc | ||
| - with: | ||
| - github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| - | ||
| - - uses: actions/cache@v4 | ||
| - with: | ||
| - path: | | ||
| - ffi/target | ||
| - glide-core/src/generated | ||
| - key: x86_64-unknown-linux-gnu-go | ||
| - restore-keys: | | ||
| - x86_64-unknown-linux-gnu-glide-core | ||
| - x86_64-unknown-linux-gnu | ||
| - - name: lint rust | ||
| - uses: ./.github/workflows/lint-rust | ||
| - with: | ||
| - cargo-toml-folder: ffi | ||
| - github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| - | ||
| - - name: Install and run linters | ||
| - working-directory: go | ||
| - run: | | ||
| - make install-dev-tools install-build-tools gen-c-bindings generate-protobuf lint-ci | ||
| - | ||
| get-containers: | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.event.inputs.full-matrix == 'true' || github.event_name == 'schedule' }} | ||
| @@ -278,8 +240,8 @@ jobs: | ||
| working-directory: go | ||
| if: ${{ github.event.inputs.rc-test != 'true' }} | ||
| run: | | ||
| - make install-tools build | ||
| - make -k unit-test integ-test | ||
edlng marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| + make install-tools | ||
| + make -k integ-test | ||
| make -k pubsub-test | ||
|
|
||
| - name: Upload test reports | ||
| @@ -401,7 +363,7 @@ jobs: | ||
| - name: Install & build & test | ||
| working-directory: go | ||
| run: | | ||
| - make install-tools build | ||
| + make install-tools | ||
| make -k long-timeout-test test-filter=TestLongTimeout | ||
|
|
||
| - name: Upload logs and reports | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
| # Start by patching | ||
| cd ../ | ||
| git apply -v go/scripts/rc-testing/gha.patch | ||
| cd go | ||
|
|
||
| # Check if version parameter is provided | ||
| if [ $# -ne 1 ]; then | ||
| echo "Usage: $0 <version>" | ||
| echo "Example: $0 v1.3.4-rc2" | ||
| exit 1 | ||
| fi | ||
|
|
||
| VERSION=$1 | ||
|
|
||
| # Validate version format | ||
| if ! [[ $VERSION =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)(-rc[0-9]+)?$ ]]; then | ||
| echo "Error: Version must be in format vX.Y.Z or vX.Y.Z-rcN (e.g., v1.3.4-rc2)" | ||
| exit 1 | ||
| else | ||
| MAJOR=${BASH_REMATCH[1]} | ||
| echo "Testing release candidate: $VERSION" | ||
| fi | ||
|
|
||
| # Create testutils directory and copy internal interfaces to avoid internal package restrictions | ||
| echo "Setting up testutils to handle internal package imports..." | ||
| mkdir -p testutils | ||
| cp -r internal/interfaces/* testutils/ | ||
|
|
||
| # Fix imports in test files to use testutils instead of internal/interfaces | ||
| echo "Updating test file imports..." | ||
| find integTest/ -name "*.go" -type f -exec grep -l "github.com/valkey-io/valkey-glide/go/v2/internal/interfaces" {} \; | while read -r file; do | ||
| echo "Updating imports in $file" | ||
| os="$(uname -s)" | ||
| if [ "$os" = "Linux" ]; then | ||
| sed -i 's|github.com/valkey-io/valkey-glide/go/v2/internal/interfaces|github.com/valkey-io/valkey-glide/go-test-rc/testutils|g' "$file" | ||
| else | ||
| # MacOS | ||
| sed -i '' 's|github.com/valkey-io/valkey-glide/go/v2/internal/interfaces|github.com/valkey-io/valkey-glide/go-test-rc/testutils|g' "$file" | ||
| fi | ||
| done | ||
|
|
||
| # Modify go.mod file | ||
| echo "Modifying go.mod file..." | ||
| # Use sed to modify the module name and add the dependency after testify depending on MacOS or Linux | ||
| os="$(uname -s)" | ||
| if [ "$os" = "Linux" ]; then | ||
| # Linux | ||
| sed -i -e 's|module github.com/valkey-io/valkey-glide/go/v2|module github.com/valkey-io/valkey-glide/go-test-rc|' go.mod | ||
| sed -i -e '/github.com\/stretchr\/testify/a\\tgithub.com/valkey-io/valkey-glide/go/v2 '"$VERSION" go.mod | ||
| # Add replace directive after the require block | ||
| sed -i -e '/^)/a\\nreplace github.com/valkey-io/valkey-glide/go/v2 => ./' go.mod | ||
| if [ $MAJOR -lt "2" ]; then # Fix for release version 1 branches | ||
| sed -i -e 's|"redis-cli",|CLI_COMMAND,|g' ../utils/cluster_manager.py | ||
| fi | ||
| else | ||
| # MacOS | ||
| sed -i '' -e 's|module github.com/valkey-io/valkey-glide/go/v2|module github.com/valkey-io/valkey-glide/go-test-rc|' go.mod | ||
| sed -i '' -e '/github.com\/stretchr\/testify/a\ | ||
| github.com/valkey-io/valkey-glide/go/v2 '"$VERSION" go.mod | ||
| # Add replace directive after the require block | ||
| sed -i '' -e '/^)/a\ | ||
| \ | ||
| replace github.com/valkey-io/valkey-glide/go/v2 => ./' go.mod | ||
| if [ $MAJOR -lt "2" ]; then # Fix for release version 1 branches | ||
| sed -i '' -e 's|"redis-cli",|CLI_COMMAND,|g' ../utils/cluster_manager.py | ||
| fi | ||
| fi | ||
|
|
||
| echo "go.mod has been updated" | ||
| go mod tidy |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this step will run tests (yes,
buildwill be odd for RC testing)