-
Notifications
You must be signed in to change notification settings - Fork 90
Go: Fix Timeout Casting in time.Duration
#3933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edlng
wants to merge
11
commits into
valkey-io:main
Choose a base branch
from
Bit-Quill:go/edlng-fix-timeout-cast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jbrinkman |
marcind
reviewed
May 22, 2025
marcind
reviewed
May 22, 2025
marcind
reviewed
May 22, 2025
marcind
reviewed
May 22, 2025
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
09177bc
to
927bde0
Compare
Signed-off-by: Edward Liang <[email protected]>
yipin-chen
approved these changes
May 23, 2025
marcind
reviewed
May 23, 2025
marcind
reviewed
May 23, 2025
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
marcind
reviewed
May 23, 2025
marcind
reviewed
May 23, 2025
marcind
reviewed
May 23, 2025
marcind
reviewed
May 23, 2025
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time.Duration
has the duration in nanoseconds. We need to ensure our casting is proper and valid to prevent any undefined behavior from occurring.Issue link
This Pull Request is linked to issue (URL): closes #3931
Checklist
Before submitting the PR make sure the following are checked: