Go: Batch #3938
Open
Go: Batch #3938
+1,607
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
6 tasks
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
yipin-chen
reviewed
May 22, 2025
yipin-chen
reviewed
May 22, 2025
yipin-chen
approved these changes
May 22, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
edlng
reviewed
May 23, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
marcind
reviewed
May 23, 2025
marcind
reviewed
May 23, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Co-authored-by: Edward Liang <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Yury-Fridlyand
requested a deployment
to
AWS_ACTIONS
GitHub Actions
Waiting
jbrinkman
approved these changes
May 27, 2025
| delete(client.pending, resultChannelPtr) | ||
| } | ||
| client.mu.Unlock() | ||
| return nil, ctx.Err() |
There was a problem hiding this comment.
Suggested change
| return nil, ctx.Err() | |
| // TODO: Need to deal with cleaning up any allocated memory | |
| return nil, ctx.Err() |
|
|
||
| // ==================== | ||
|
|
||
| // TODO - move this struct and convert methods to internals |
There was a problem hiding this comment.
If this is moved to internal, how would anyone use this Option? Why not just define this as batchOptions which would prevent creating the type, while still allowing the use of the type.
|
|
||
| // ==================== | ||
|
|
||
| func (b Batch) Convert(response []any) ([]any, error) { |
jbrinkman
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust/FFI code copied and adopted from C# client.
Issue link
This Pull Request is linked to issue (URL): closes #3547, #2791
Checklist
Before submitting the PR make sure the following are checked: