Core/Batch: Add handling for server errors in value conversion #3942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shoham Elias <[email protected]>
barshaul
approved these changes
May 22, 2025
|
Please add short description to the PR and add the bug fix to the CHANGELOG |
Yury-Fridlyand
approved these changes
May 22, 2025
smas-provenir
pushed a commit
to mthemis-provenir/valkey-glide
that referenced
this pull request
May 26, 2025
…y-io#3942) Signed-off-by: Shoham Elias <[email protected]> Signed-off-by: Santiago, Mas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents commands that encountered a ServerError from being converted to their expected types (e.g., HGETALL to Map). This ensures that batch responses with errors are handled safely and do not cause type conversion issues.
Issue link
This Pull Request is linked to issue (URL): #3937
Checklist
Before submitting the PR make sure the following are checked: