Skip to content

Opentelemetry - set status, moved counter, retry_attempts counter #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Maayanshani25
Copy link
Collaborator

@Maayanshani25 Maayanshani25 commented May 22, 2025

Issue link

This Pull Request is linked to issue (URL): #3812 , #3629

Set status to ok and Error according to the result.
Test for set_status options.

Add metrics of moved and retry_attempt.
Tests for the new metrics recorded on regular command, atomic pipepline, and non atomic pipeline.

  • If moved happend it will record retry and moved metrics.
  • If different retry it will record only retry metric

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@Maayanshani25 Maayanshani25 requested a review from a team as a code owner May 22, 2025 10:01
@Maayanshani25 Maayanshani25 self-assigned this May 22, 2025
@Maayanshani25 Maayanshani25 force-pushed the otel-metrics-status branch 2 times, most recently from a45d1da to 37e53fe Compare May 25, 2025 14:21
Signed-off-by: Maayan Shani <[email protected]>
Signed-off-by: Maayan Shani <[email protected]>
Signed-off-by: Maayan Shani <[email protected]>
Signed-off-by: Maayan Shani <[email protected]>
Signed-off-by: Maayan Shani <[email protected]>
@Maayanshani25 Maayanshani25 force-pushed the otel-metrics-status branch from 343cd10 to 8c86613 Compare May 27, 2025 09:53
Signed-off-by: Maayan Shani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant