Skip to content

Go: Fix Makefile Path for Unit Test #3961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

edlng
Copy link
Collaborator

@edlng edlng commented May 23, 2025

Running unit-test locally would return Makefile Error 141 (which I think stems from the command treating utils as a different package. This patch makes it work on both CI and local testing.

~ make unit-test
mkdir -p reports
set -o pipefail; \
        go test -v ./... -skip 'Example|TestGlideTestSuite'  \
        | tee >(go tool test2json -t -p github.com/valkey-io/valkey-glide/go/v2 utils | go-test-report -o reports/unit-tests.html -t unit-test > /dev/null)
make: *** [unit-test] Error 141

Issue link

This Pull Request is linked to issue (URL): #3960

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Edward Liang <[email protected]>
@edlng edlng self-assigned this May 23, 2025
@edlng edlng requested a review from a team as a code owner May 23, 2025 19:25
@edlng edlng added the go golang wrapper label May 23, 2025
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Good catch

@edlng edlng merged commit 036c57f into main May 26, 2025
133 of 139 checks passed
@edlng edlng deleted the go/edlng-fix-makefile-ut-path branch May 26, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants