-
Notifications
You must be signed in to change notification settings - Fork 127
[All clients] Add TCPNoDelay option #5100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
shohamazon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed the core :)
jduo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this field a bool rather than an Option
d0eeb8d to
6e071c4
Compare
|
@shohamazon @jduo thank you for your reviews. On the decision to make it optional, it is a backwards compatibility consideration, so that if other external binding upgrade to this version of glide core, but hasn't added the TCPNoDelay option, they can still work. Will move the default to true logic to the rust side FFI boundary, so that all rust definition can be simplified as Please comment on this approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion - let's describe in README.md this new option, its default, and when users should change it.
Talked to @Aryex and apparently we are currently generating documentation from comments in code. Given we already have detailed comments in code for all 4 bindings (Go, Java, Node and Python), I'd say we are good. |
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
Signed-off-by: James Xin <[email protected]>
73d4c22 to
e127f13
Compare
Issue link
This Pull Request is linked to issue (URL): #5113
Checklist
Before submitting the PR make sure the following are checked: