-
Notifications
You must be signed in to change notification settings - Fork 127
feat(java): add support for KEYS, MIGRATE, and WAITAOF commands #5107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sasidharan3094
wants to merge
15
commits into
valkey-io:main
Choose a base branch
from
Sasidharan3094:implement-generic-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(java): add support for KEYS, MIGRATE, and WAITAOF commands #5107
Sasidharan3094
wants to merge
15
commits into
valkey-io:main
from
Sasidharan3094:implement-generic-commands
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
…uster mode Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Signed-off-by: Sasidharan Gopal <[email protected]>
Contributor
Author
|
@yipin-chen @alexr-bq @xShinnRyuu Please review this PR and retry the failed checks as they are transient errors. Thanks. |
Signed-off-by: Sasidharan Gopal <[email protected]>
Contributor
Author
|
@yipin-chen @alexr-bq Please review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for KEYS, MIGRATE, and WAITAOF commands in Java client
This fixes the issue
Description
This PR adds support for three Redis/Valkey commands to the Java client:
Changes Made
1. KEYS Command
keys(String pattern)andkeys(GlideString pattern)toGenericBaseCommandsinterfaceBaseClientfor standalone modeGlideClusterClientfor cluster mode (routes to all primary nodes)2. MIGRATE Command
migrate(String host, long port, String key, long destinationDB, long timeout)toGenericBaseCommandsinterfacemigrate(String host, long port, GlideString key, long destinationDB, long timeout)variantMigrateOptionsparameter for COPY, REPLACE, AUTH, and AUTH2 optionsMigrateOptionsmodel class with builder patternBaseClientandGlideClusterClient3. WAITAOF Command
waitaof(long numlocal, long numreplicas, long timeout)toGenericBaseCommandsinterfaceBaseClientandGlideClusterClientLong[]array with [local_acks, replica_acks]Files Modified
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java- Added interface methodsjava/client/src/main/java/glide/api/BaseClient.java- Added implementationsjava/client/src/main/java/glide/api/GlideClusterClient.java- Added cluster implementationsFiles Created
java/client/src/main/java/glide/api/models/commands/MigrateOptions.java- Options class for MIGRATE commandImplementation Details
WaitAof,Keys, andMigrateimports to both client classeswait()) as referenceTesting
Checklist
Additional Notes