Configure black to lint Jupyter notebooks#272
Conversation
c39d74e to
48d034c
Compare
|
Rebased on |
|
Thanks for your PR. Hold it without rebasing for now. I have some plans of improving the CI on that part. Once I've done this, we'll get back to your PR. |
|
@mkmkme Have you had a chance to implement your plans? If you haven't started, I'm hopeful that this can merge as-is, rather than being blocked on future work. |
|
@kurtmckee no, not yet. If you want to get this PR merged asap, I'd suggest limiting its scope to only cover linting and formatting Jupyter notebooks and dropping 3.10 syntax. Targeting py3.10 is potentially a larger task and it requires:
All of those should be done in separate commits. Also, I would like to do that after all currently pending PRs that I want to merge for the next release. Therefore, bumping the |
|
This PR already reformatted the code base -- two test files and |
ba00416 to
062ba2a
Compare
Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
Signed-off-by: Kurt McKee <contactme@kurtmckee.org>
062ba2a to
d776cfa
Compare
|
@mkmkme I've updated the PR to merely target Jupyter notebooks, and I've rewritten the history so that the reformatting happens in a separate commit. 👍 Thanks for your explaining your reasoning! My goal is to continue hammering on the project infrastructure so that the project becomes easier to maintain, and risking causing additional work in existing PRs definitely was not an outcome I had considered. |
mkmkme
left a comment
There was a problem hiding this comment.
Looks great now, thanks a lot! 👍
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 76.40% 76.40%
=======================================
Files 129 129
Lines 34065 34065
=======================================
Hits 26027 26027
Misses 8038 8038 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request check-list
Description of change
This PR introduces the following changes:
Black's
jupyterextra is added, which allows it to lint Jupyter notebooks.The
docs/directory is added to the list of directories to lint, so that black can lint the Jupyter notebooks there.After making these changes to
pyproject.tomlandMakefile, this command was run: