Skip to content

added support for CAPA redirect#278

Open
mkmkme wants to merge 3 commits intomainfrom
mkmkme/capa-redirect
Open

added support for CAPA redirect#278
mkmkme wants to merge 3 commits intomainfrom
mkmkme/capa-redirect

Conversation

@mkmkme
Copy link
Copy Markdown
Collaborator

@mkmkme mkmkme commented Mar 18, 2026

fixes #235

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

@mkmkme mkmkme added this to the 7.0.0 milestone Mar 18, 2026
@mkmkme mkmkme added the feature label Mar 18, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.48%. Comparing base (5c9a506) to head (70885ca).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
valkey/connection.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   76.41%   76.48%   +0.06%     
==========================================
  Files         129      129              
  Lines       34065    34176     +111     
==========================================
+ Hits        26031    26139     +108     
- Misses       8034     8037       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkmkme mkmkme force-pushed the mkmkme/capa-redirect branch from 37b2b6c to d425cfa Compare March 18, 2026 21:16
@mkmkme mkmkme marked this pull request as ready for review March 18, 2026 21:17
Copy link
Copy Markdown
Collaborator

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks correct, minor comments

@mkmkme mkmkme force-pushed the mkmkme/capa-redirect branch 2 times, most recently from f857f4e to ad0de76 Compare March 28, 2026 07:32
mkmkme added 3 commits March 28, 2026 08:32
fixes #235

Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
Signed-off-by: Mikhail Koviazin <github@mkmk.aleeas.com>
@mkmkme mkmkme force-pushed the mkmkme/capa-redirect branch from ad0de76 to 70885ca Compare March 28, 2026 07:32
@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Mar 28, 2026

@bogdanp05 could you have another look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Client CAPA redirect

4 participants