Make skip_ifmodversion_lt skip not installed modules#302
Merged
bogdanp05 merged 1 commit intovalkey-io:mainfrom Apr 23, 2026
Merged
Make skip_ifmodversion_lt skip not installed modules#302bogdanp05 merged 1 commit intovalkey-io:mainfrom
bogdanp05 merged 1 commit intovalkey-io:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
- Coverage 76.72% 76.70% -0.02%
==========================================
Files 129 129
Lines 34146 34146
==========================================
- Hits 26198 26193 -5
- Misses 7948 7953 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Matteo Centenaro <matteo.centenaro@aiven.io>
64a5f70 to
df5c449
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
skip_ifmodversion_ltshould not make a test to fail, if the needed module is not enabled. Here the marker is updated to skip the test in that case, instead.