Skip to content

Make skip_ifmodversion_lt skip not installed modules#302

Merged
bogdanp05 merged 1 commit intovalkey-io:mainfrom
bugant:bugant-fix-skip_ifmodversion_lt
Apr 23, 2026
Merged

Make skip_ifmodversion_lt skip not installed modules#302
bogdanp05 merged 1 commit intovalkey-io:mainfrom
bugant:bugant-fix-skip_ifmodversion_lt

Conversation

@bugant
Copy link
Copy Markdown
Contributor

@bugant bugant commented Apr 22, 2026

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

skip_ifmodversion_lt should not make a test to fail, if the needed module is not enabled. Here the marker is updated to skip the test in that case, instead.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.70%. Comparing base (ab36c7a) to head (df5c449).

Files with missing lines Patch % Lines
tests/conftest.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   76.72%   76.70%   -0.02%     
==========================================
  Files         129      129              
  Lines       34146    34146              
==========================================
- Hits        26198    26193       -5     
- Misses       7948     7953       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Matteo Centenaro <matteo.centenaro@aiven.io>
@bugant bugant force-pushed the bugant-fix-skip_ifmodversion_lt branch from 64a5f70 to df5c449 Compare April 23, 2026 07:04
Copy link
Copy Markdown
Collaborator

@bogdanp05 bogdanp05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bogdanp05 bogdanp05 enabled auto-merge April 23, 2026 08:52
@bogdanp05 bogdanp05 merged commit 29039f6 into valkey-io:main Apr 23, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants