Add SeekForwardPosition API to TextIterator interface and all the derived iterators #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KarthikSubbarao <[email protected]>
…imityiterator Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
src/indexes/text/proximity.cc
Outdated
| } | ||
| // No violations: advance the term appearing first physically | ||
| size_t first_idx = in_order_ ? 0 : pos_with_idx_[0].second; | ||
| if (!iters_[first_idx]->DonePositions()) { |
Collaborator
There was a problem hiding this comment.
What would happen if the iterator is exhausted?
Member
Author
There was a problem hiding this comment.
If it was exhausted, then we should not try advancing, since it is against the contract (and can crash). There is a check at the top in the loop condition which will exit if any iterator is done once the curr iteration is done
Signed-off-by: KarthikSubbarao <[email protected]>
Signed-off-by: KarthikSubbarao <[email protected]>
daddaman-amz
approved these changes
Jan 20, 2026
eliastam
pushed a commit
to eliastam/valkey-search
that referenced
this pull request
Jan 21, 2026
…ived iterators (valkey-io#620) * seekforwardposition Signed-off-by: KarthikSubbarao <[email protected]> * implement seekforward for unordered positions case and also in orproximityiterator Signed-off-by: KarthikSubbarao <[email protected]> * updates Signed-off-by: KarthikSubbarao <[email protected]> * Cleaning code Signed-off-by: KarthikSubbarao <[email protected]> * Refactor Signed-off-by: KarthikSubbarao <[email protected]> * cleanup Signed-off-by: KarthikSubbarao <[email protected]> * Add comment Signed-off-by: KarthikSubbarao <[email protected]> * fix Signed-off-by: KarthikSubbarao <[email protected]> * Remove noop check Signed-off-by: KarthikSubbarao <[email protected]> --------- Signed-off-by: KarthikSubbarao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SeekForwardPosition API to TextIterator interface and all the derived iterators.
This will help in cases where there is an ordering violation identified based on the initial primed positions of the text iterators. To resolve the ordering violation, we try to seek when possible to avoid repetitive NextPosition calls
Note: It will only ever be used by an search query with an AND Intersection with some proximity property thus requiring a ProximityIterator