Skip to content

Log failed cluster node(s) state periodically to capture transient state for debuggability #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hpatro wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Log failed cluster node(s) state periodically to capture transient state for debuggability #2011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/cluster_legacy.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5533,6 +5533,24 @@ void clusterCron(void) {
}

if (update_state || server.cluster->state == CLUSTER_FAIL) clusterUpdateState();

/* Log cluster info and nodes information for better debugability of the transient cluster state */
if (server.verbosity <= LL_VERBOSE) {
run_with_period(5000) {
sds cluster_info = genClusterInfoString();
sds cluster_nodes = clusterGenNodesDescription(NULL, 0, 0);

sds infostring = sdscatprintf(sdsempty(), "\r\n# Cluster info\r\n");
Copy link
Member

@madolson madolson Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New lines break log parsing. If someone turns on for some reason, it should still be "valid" log lines. I'm OK logging the state, but I don't think it should just be verbatim the info fields.

Copy link
Contributor Author

@hpatro hpatro Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. So, it's an exception for crash report to have new lines?

Copy link
Contributor Author

@hpatro hpatro Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madolson and I discussed offline. We discussed we can have a single log line with information around failed nodes rather than all the nodes.

infostring = sdscatsds(infostring, cluster_info);
infostring = sdscatprintf(infostring, "\n------ CLUSTER NODES OUTPUT ------\n");
infostring = sdscatsds(infostring, cluster_nodes);
serverLog(LL_VERBOSE, "%s", infostring);

sdsfree(cluster_info);
sdsfree(cluster_nodes);
sdsfree(infostring);
}
}
}

/* This function is called before the event handler returns to sleep for
Expand Down
Loading