Remove duplicate macro definitions of HASH_SET_* #2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vitah <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #2024 +/- ##
=========================================
Coverage 70.99% 70.99%
=========================================
Files 123 123
Lines 66116 66116
=========================================
Hits 46942 46942
Misses 19174 19174
🚀 New features to boost your workflow:
|
zuiderkwast
approved these changes
May 5, 2025
zuiderkwast
changed the title
SoftlyRaining
pushed a commit
to SoftlyRaining/valkey
that referenced
this pull request
May 14, 2025
This PR removes duplicate macro definitions of HASH_SET_TAKE_FIELD, HASH_SET_TAKE_VALUE, and HASH_SET_COPY that were already defined in `server.h`. Keeping a single definition helps ensure consistency and avoids redundancy across files. https://github.com/valkey-io/valkey/blob/25ef0b3aff50864eba89f4ca6d8b56f8ff07690c/src/server.h#L3265-L3268 Signed-off-by: vitah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes duplicate macro definitions of HASH_SET_TAKE_FIELD, HASH_SET_TAKE_VALUE, and HASH_SET_COPY that were already defined in
server.h. Keeping a single definition helps ensure consistency and avoids redundancy across files.valkey/src/server.h
Lines 3265 to 3268 in 25ef0b3