Skip to content

Remove duplicate macro definitions of HASH_SET_TAKE_FIELD, HASH_SET_TAKE_VALUE, and HASH_SET_COPY #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: unstable
Choose a base branch
from

Conversation

vitahlin
Copy link
Contributor

This PR removes duplicate macro definitions of HASH_SET_TAKE_FIELD, HASH_SET_TAKE_VALUE, and HASH_SET_COPY that were already defined in server.h. Keeping a single definition helps ensure consistency and avoids redundancy across files.

valkey/src/server.h

Lines 3265 to 3268 in 25ef0b3

#define HASH_SET_TAKE_FIELD (1 << 0)
#define HASH_SET_TAKE_VALUE (1 << 1)
#define HASH_SET_COPY 0

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (25ef0b3) to head (17a3dc5).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #2024   +/-   ##
=========================================
  Coverage     70.99%   70.99%           
=========================================
  Files           123      123           
  Lines         66116    66116           
=========================================
  Hits          46942    46942           
  Misses        19174    19174           
Files with missing lines Coverage Δ
src/t_hash.c 96.19% <ø> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant