Defer command execution during long-running scripts#3363
Open
amanosme wants to merge 3 commits intovalkey-io:unstablefrom
Open
Defer command execution during long-running scripts#3363amanosme wants to merge 3 commits intovalkey-io:unstablefrom
amanosme wants to merge 3 commits intovalkey-io:unstablefrom
Conversation
Signed-off-by: Tyler Amano-Smerling <amanosmerling@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3363 +/- ##
============================================
- Coverage 74.53% 74.51% -0.03%
============================================
Files 130 130
Lines 72731 72730 -1
============================================
- Hits 54208 54192 -16
- Misses 18523 18538 +15
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing open issue #3218
This PR changes the default response to command execution after
busy-reply-thresholdis exceeded, where the issuing client will be blocked (and added to postponed client list) until the script is through executing.I chose to leave the logic for FUNCTION STATS unchanged, where the command will still return
-BUSYerror forEVALscripts. It seemed to me that we intentionally don't want to show function stats forEVAL, but I can remove these lines if we decide otherwise.Most of the changes were to adjust how tests check that a script is timed out- we verify
-BUSYresponse toFUNCTION STATSforEVALscripts, and for functions we useFUNCTION STATSto check how long the script has been running. This also changes the expected behavior forMULTItransactions sent during timeout, where we expect all transactions to execute once we issueSCRIPT KILL/FUNCTION KILL, so the multi tests were updated accordingly.