ci: include gtests in code coverage report#3385
Merged
JimB123 merged 2 commits intovalkey-io:unstablefrom Mar 24, 2026
Merged
Conversation
harrylin98
force-pushed
the
Fix_code_cov
branch
5 times, most recently
from
2aa0f43 to
ae881d3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3385 +/- ##
============================================
+ Coverage 74.93% 76.43% +1.49%
============================================
Files 130 159 +29
Lines 72769 79652 +6883
============================================
+ Hits 54532 60884 +6352
- Misses 18237 18768 +531 🚀 New features to boost your workflow:
|
harrylin98
force-pushed
the
Fix_code_cov
branch
2 times, most recently
from
fa8cdb3 to
018871c
Compare
Signed-off-by: harrylin98 <harrylin980107@gmail.com>
harrylin98
force-pushed
the
Fix_code_cov
branch
from
018871c to
3f4a300
Compare
Contributor
|
@harrylin98 how did you test this? |
Contributor
Author
|
@sarthakaggarwal97 I added this change to PR #3341. Since this is an internal API, the PR only has unit tests and no integration tests. Previously, Codecov reported almost all lines in the new feature files as missing because valkey.info didn’t detect related integration tests. After this change, patch coverage is now 98% with only 8 lines missing. 
|
JimB123
approved these changes
Mar 23, 2026
sarthakaggarwal97
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change includes running gtest unit tests in the code coverage report.