Skip to content

feat(modal): add container option to append modals to custom elements #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

valorkin
Copy link
Member

Summary

  • Add container option to ModalOptions allowing modals to be appended to custom elements
  • Supports both string selectors and direct Element references
  • Updates BsModalService to use custom container for both modal and backdrop
  • Maintains full backward compatibility with default 'body' container

Test plan

  • Container option works with string selectors
  • Container option works with Element references
  • Multiple modals can use different containers
  • Backward compatibility maintained when no container specified
  • Unit tests cover all container scenarios and edge cases
  • E2E tests verify behavior in real browser environment
  • No regressions in existing modal functionality

🤖 Generated with Claude Code

valorkin and others added 2 commits May 26, 2025 17:51
- Add container option to ModalOptions (string selector or Element)
- Update BsModalService to use custom container instead of hardcoded 'body'
- Apply container option to both modal and backdrop components
- Maintain backward compatibility with default 'body' container
- Add comprehensive unit tests for container functionality
- Add E2E tests to verify modal container behavior

Fixes #731

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented May 26, 2025

Deploying ngx-bootstrap with  Cloudflare Pages  Cloudflare Pages

Latest commit: 051d5ad
Status:🚫  Build failed.

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant