feat(tabs): add beforeRemove event to allow canceling tab removal#6751
Open
valorkin wants to merge 3 commits intodevelopmentfrom
Open
feat(tabs): add beforeRemove event to allow canceling tab removal#6751valorkin wants to merge 3 commits intodevelopmentfrom
valorkin wants to merge 3 commits intodevelopmentfrom
Conversation
- Add beforeRemove event to TabDirective that emits before tab removal - Allow cancellation by calling event.preventDefault() in the event handler - Update TabsetComponent.removeTab() to check for cancellation before proceeding - Maintain full backward compatibility with existing removed event - Add comprehensive unit tests for all cancellation scenarios - Add E2E tests to verify tab removal cancellation behavior Fixes #786 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying ngx-bootstrap with
|
| Latest commit: |
d69b198
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code