Skip to content

feat(typeahead): add support for multiple datasets in typeahead #6752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

valorkin
Copy link
Member

Summary

  • Add support for multiple datasets in typeahead similar to Twitter's typeahead.js
  • Developers can now provide multiple data sources with different configurations
  • Each dataset can have its own display field, search field, header, and limit
  • Results are merged and optionally grouped by dataset with headers
  • Maintains full backward compatibility with existing single dataset usage

Test plan

  • Multiple datasets can be configured with different sources
  • Dataset-specific configurations (headers, limits, fields) work correctly
  • Results are properly merged and grouped by dataset
  • Backward compatibility maintained with single typeahead input
  • Unit tests cover all multiple datasets scenarios and edge cases
  • E2E tests verify behavior in real browser environment
  • No regressions in existing typeahead functionality

🤖 Generated with Claude Code

valorkin and others added 2 commits May 26, 2025 18:43
- Add TypeaheadDataset interface for configuring multiple data sources
- Add typeaheadDatasets input property to TypeaheadDirective
- Implement processMultipleDatasets method to handle multiple sources
- Support dataset-specific configuration (headers, limits, display fields)
- Maintain full backward compatibility with single typeahead input
- Add comprehensive unit tests for multiple datasets functionality
- Add E2E tests to verify multiple datasets behavior

Fixes #794

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

cloudflare-workers-and-pages bot commented May 26, 2025

Deploying ngx-bootstrap with  Cloudflare Pages  Cloudflare Pages

Latest commit: a1dbd88
Status:🚫  Build failed.

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant