Skip to content

Gas estimate multiplier on txSettler#2394

Merged
jmoreira-valory merged 2 commits intomainfrom
feat/gas_estimate_multiplier
Feb 5, 2026
Merged

Gas estimate multiplier on txSettler#2394
jmoreira-valory merged 2 commits intomainfrom
feat/gas_estimate_multiplier

Conversation

@jmoreira-valory
Copy link
Collaborator

Proposed changes

Gas estimate multiplier on txSettler

Fixes

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run AI agents that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

OjusWiZard
OjusWiZard previously approved these changes Feb 5, 2026
Copy link
Member

@OjusWiZard OjusWiZard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a small check for this in the TxSettler's unit tests?

Co-authored-by: Adamantios Zaras <adamantioszaras@gmail.com>
@jmoreira-valory jmoreira-valory merged commit 67fbafb into main Feb 5, 2026
14 of 16 checks passed
@jmoreira-valory jmoreira-valory deleted the feat/gas_estimate_multiplier branch February 6, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants