Skip to content

feat(offchain): wire mech-interact off-chain branch through Trader FSM #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DIvyaNautiyal07 merged 4 commits into from
Jul 1, 2026
Merged

feat(offchain): wire mech-interact off-chain branch through Trader FSM #1002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
471646e
feat(offchain): wire mech-interact off-chain branch through Trader FSM
DIvyaNautiyal07 Jun 30, 2026
782233e
fix(offchain): address PR #1002 review — contract registration + nati…
DIvyaNautiyal07 Jul 1, 2026
478e0a5
chore: satisfy CI flake8 docstring (D205) on new test
DIvyaNautiyal07 Jul 1, 2026
0956931
fix(offchain): polymarket_trader parity + bare-dev cap default
DIvyaNautiyal07 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions packages/packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
"contract/valory/deposit_wallet/0.1.0": "bafybeidjkryojg7cv4hrjvrd2hm5cv5kdoqrmhdsxyjriwtdpo4v3avoia",
"connection/valory/polymarket_client/0.1.0": "bafybeid4eo37pka4tfhsjs6rb3knrugmokcvihust2dpfrgob56y77xd44",
"skill/valory/market_manager_abci/0.1.0": "bafybeic67hypwetzltnuy3a6y3o2o332lxyvn34buq57gy4n6bfqpbpxjm",
"skill/valory/decision_maker_abci/0.1.0": "bafybeigterfcylnzjzxpja6u56gvcq2grcgvia2qcj34yr2ksogss33wuu",
"skill/valory/trader_abci/0.1.0": "bafybeifepfhwcrbinv22hlltrf2cfacqybzsdnm63knw73yc5yfoer3ks4",
"skill/valory/tx_settlement_multiplexer_abci/0.1.0": "bafybeiglvalfzo744cvxvslx4vo42r4tcozn7hzsn3aa2q3hkm77t77xwe",
"skill/valory/decision_maker_abci/0.1.0": "bafybeiebddoshz7szs22sm7fn2cb4ywb6oa46ohc2naqcoznggb3nde43u",
"skill/valory/trader_abci/0.1.0": "bafybeigkd4zkooaeng7ujroqpletfslja23fn6e6x4zuneictevpgeqw7y",
"skill/valory/tx_settlement_multiplexer_abci/0.1.0": "bafybeighlmd4xj64qf3xtgbcxvqnipcnsvv47npkrlatngan2e6r23elhm",
"skill/valory/staking_abci/0.1.0": "bafybeihwyron2bv7ierrgxke7xofwjy7x6wtglg5vopon7i7lfdiivweaq",
"skill/valory/agent_performance_summary_abci/0.1.0": "bafybeigmmvpncem6i6t57nwjqzajrbnf6rnqgp43mlo6jf6uziq6lrhlca",
"skill/valory/check_stop_trading_abci/0.1.0": "bafybeifbiko6p3sqqg2q6qemmcig432s5djcsxm44j35ejittlpyr5f6z4",
"skill/valory/check_stop_trading_abci/0.1.0": "bafybeiexmdtj3qfjnhh2sy3fa4hwxkvqogsy7u46liobzhgilzogeoezeu",
"skill/valory/chatui_abci/0.1.0": "bafybeie2kmgihgk3rwpzelaa76ypvchsyg2vy3me4vxlbjttaq4frs3ipa",
"agent/valory/trader/0.1.0": "bafybeifdcmuilvxj5gf3d7dumlgcab3qwsp2xkmhqfnfxef3zxulpbthxy",
"service/valory/trader_pearl/0.1.0": "bafybeigqqgmku426wk2pr2344s4347qmxozppwuexdup3ugwj36aasdq64",
"service/valory/polymarket_trader/0.1.0": "bafybeign7qvajyzxojpd2iokvitfil2ygnazpn5w6uyq2u7aex4s5hf5za"
"agent/valory/trader/0.1.0": "bafybeievk35g3mszasfdeuumig63wqir2h27g6kqmaw4f4vrvg7cvar5ya",
"service/valory/trader_pearl/0.1.0": "bafybeiahpvkxhi7bdpdrl25ndzlcfnm4x6r4ot5ops3wpdza5562poweiu",
"service/valory/polymarket_trader/0.1.0": "bafybeidq7gsdnapl74xlplw27x4a3kq7cuqsxwv3aphfq54jlnzfb7chyq"
},
"third_party": {
"protocol/valory/acn_data_share/0.1.0": "bafybeieqisfr6lhaaesq37lk7vyaxza2h6nucshksgyo2djqfyf2saqo4i",
Expand Down Expand Up @@ -55,6 +55,9 @@
"contract/valory/agreement_store_manager/0.1.0": "bafybeign6u6635cpp7z2rws7uaaxgzvyokdyzztnadmivbt2qsvw2q2vza",
"contract/valory/transfer_nft_condition/0.1.0": "bafybeib6wigs3ufiuzkj6twlthcya67lswm3qosikrg4ez7jjgkam4kz5m",
"contract/valory/subscription_provider/0.1.0": "bafybeia7fmpemztyjwu4pu4p3q2udy7ymrxz4p5eklegdlc2bgnfi2zoae",
"contract/valory/mech_marketplace/0.1.0": "bafybeieadbmhzndxe6jcfwujcpjrljpc5kfwffkd3zzpg75uxksufn4l3i",

@bennyjo bennyjo Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three contracts (mech_marketplace, balance_tracker_fixed_price_native, balance_tracker_fixed_price_token) are vendored here and declared by the upstream mech_interact_abci skill, but they aren't added to the contracts: section of packages/valory/agents/trader/aea-config.yaml — where every other mech-interact contract (mech, mech_mm, mech_marketplace_legacy, nvm_balance_tracker_*, agent_mech) is explicitly listed. The agent loads only the components in that section, so the first off-chain contract call when use_offchain: true (MechMarketplace.get_nonce/get_chain_id/get_balance_tracker, or the balance-tracker reads) won't resolve at runtime.

The twin optimus#355 has the identical omission, and the end-to-end verification noted in the description appears to exercise the mech side rather than a trader agent built from this branch with use_offchain: true — so the trader-side registration looks untested. Could you confirm a trader agent built from this branch resolves these three contracts? If not, they need adding to the contracts: section of packages/valory/agents/trader/aea-config.yaml, and mirrored in optimus#355.

@DIvyaNautiyal07 DIvyaNautiyal07 Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and fixed in 5ef4591. Verified locally — the three contracts (mech_marketplace, balance_tracker_fixed_price_native, balance_tracker_fixed_price_token) were indeed missing from the agent's contracts: section, added alongside the existing mech-interact entries in packages/valory/agents/trader/aea-config.yaml. Good catch — the multi-round Claude iterations on this PR were focused on FSM wiring and missed that the vendored contracts (which are declared in the skill) still need to be enumerated at the agent level to load at runtime. Mirroring the same fix into optimus#355 as a follow-up commit.

"contract/valory/balance_tracker_fixed_price_native/0.1.0": "bafybeifobvptvc7mkrztfij664dqqegl6qi32773zewvyuftes32faemw4",
"contract/valory/balance_tracker_fixed_price_token/0.1.0": "bafybeienpn5nb7mgiw5uitm5mjwcgc2xd7bzx5rxu2mqsvjziwvlg6poxa",
"connection/valory/http_client/0.23.0": "bafybeihel6sg2yayxu7lqygaswdgciaxpqrgsbl5rwx74c6znu5qz2edd4",
"connection/valory/p2p_libp2p_client/0.1.0": "bafybeielj3jso3wvrarp5n5rq7llpw4vgxybqiyensgjalb5ubfiawwhhu",
"connection/valory/x402/0.1.0": "bafybeicqjg3d6pnlcsu4442qt5tmsjqkqdtc3ulvbjgoh53jyr7z3lbqqi",
Expand All @@ -69,7 +72,7 @@
"skill/valory/registration_abci/0.1.0": "bafybeihjhbn5seffyu5cwugvm26fkamp3svhggmtzh577daijgl2ksxs3e",
"skill/valory/reset_pause_abci/0.1.0": "bafybeihc4ruh25s7wuunfy2b3k2n4eypyhvtry3usgom44wsymagbcr3ki",
"skill/valory/termination_abci/0.1.0": "bafybeibnnzry5kknci3z46gcjgutv4jid3ir6xn6a5adq3tx6v2e25augq",
"skill/valory/mech_interact_abci/0.1.0": "bafybeidnmszufszq3ro4ebgrqzmhqgctrsc6sykeanfsbvotghvt2cgfsy",
"skill/valory/mech_interact_abci/0.1.0": "bafybeihhwzpa6x5ypth426tzd2zjsnys6jmjaab4zvk4edisetzktft754",

@OjusWiZard OjusWiZard Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — branch is non-functional as committed.

This bumps mech_interact_abci to the rc1 CID (bafybeihhwzpa…) here and in every skill.yaml/aea-config.yaml ref, but the vendored source under packages/valory/skills/mech_interact_abci/ was never synced — it's still the old version. None of the off-chain symbols the trader-side code imports exist there:

ImportError: cannot import name 'OFFCHAIN_DEPOSIT_TX_SUBMITTER'
  from '...mech_interact_abci.states.request'
ImportError: cannot import name 'FinishedOffchainMechRequestRound'
  from '...mech_interact_abci.states.final_states'

grep confirms mech_request_round_offchain_deposit and the offchain rounds appear only in this PR's four trader files, nowhere in the mech_interact package. Consequences:

  • composition.py, handle_failed_tx.py, tx_settlement_multiplexer_abci/rounds.py and all three touched test modules fail at collection time → agent won't start, suite can't run.
  • autonomy packages lock --check will fail: this line claims the new CID but the vendored source still hashes to the old bafybeidnmsz….

This contradicts the PR description's "All 1537 tests pass locally" and "packages lock --check green" — those hold only in a local tree where rc1 was synced but not committed.

Fix: sync + commit the mech_interact_abci v0.32.4-rc1 source onto the branch (or land it on offchain-epic first and confirm it's present in the merge target).

@DIvyaNautiyal07 DIvyaNautiyal07 Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug — vendored source path. packages/valory/skills/mech_interact_abci/ is gitignored in trader (see .gitignore line 16); the source is downloaded by CI via autonomy packages sync at test time against the hash in packages.json, and the committed hash matches v0.32.4-rc1. Same pattern as abstract_round_abci, registration_abci, all other imported skills. That's why (a) CI is green on this branch (all 14 checks including lock_check and test suites pass on the current commit) and (b) my local claim of "1687 tests pass / lock --check green" is accurate — the runner and my local venv both synced rc1. If we ever move to committing the source into the tree, that's a repo-wide decision and needs applying to every third-party skill, not just this PR.

@OjusWiZard OjusWiZard Jul 1, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right — retracting this. Confirmed .gitignore:16 ignores packages/valory/skills/mech_interact_abci/ and git ls-files shows it untracked (same as abstract_round_abci et al.), so CI syncs the rc1 source by the packages.json hash and lock --check validates against IPFS, not the working tree. My ImportError was a stale local autonomy packages sync cache, not a defect in the branch. Apologies for the noise — not a blocker.

"skill/valory/funds_manager/0.1.0": "bafybeibne4vkmbper3ryn7q6kt7lclbyylgorziscyn6msr5qt46aihv4m"
}
}
13 changes: 8 additions & 5 deletions packages/valory/agents/trader/aea-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ contracts:
- valory/ierc1155:0.1.0:bafybeif3wfclopxa3panep4xzgodlfclgypm3balncxyuxbhhvgz7imulq
- valory/nvm_balance_tracker_token:0.1.0:bafybeifwxkaobltpm77oh2b54kuclm4vtx2bzpuoowqfdemkex5gb5yyfa
- valory/nvm_balance_tracker_native:0.1.0:bafybeibou3doazirk637cyey4o33pz7fpdm4hsgdj7vd2kctuqxtjgnmla
- valory/mech_marketplace:0.1.0:bafybeieadbmhzndxe6jcfwujcpjrljpc5kfwffkd3zzpg75uxksufn4l3i
- valory/balance_tracker_fixed_price_native:0.1.0:bafybeifobvptvc7mkrztfij664dqqegl6qi32773zewvyuftes32faemw4
- valory/balance_tracker_fixed_price_token:0.1.0:bafybeienpn5nb7mgiw5uitm5mjwcgc2xd7bzx5rxu2mqsvjziwvlg6poxa
- valory/escrow_payment_condition:0.1.0:bafybeibux6vafcoevxqz3s7goyv2mdq6pxjlvw62ewclhngo3xcm23i6r4
- valory/did_registry:0.1.0:bafybeiaz5vsh2qkcbjzteada32kz5l3xfwioo7tsrz5pa3zncz63gj7jye
- valory/nft_sales:0.1.0:bafybeiacttyhd4re5jaybtvoawlzsoxhy2npavwc7k7isqhuv6s73cc7be
Expand All @@ -66,13 +69,13 @@ skills:
- valory/reset_pause_abci:0.1.0:bafybeihc4ruh25s7wuunfy2b3k2n4eypyhvtry3usgom44wsymagbcr3ki
- valory/termination_abci:0.1.0:bafybeibnnzry5kknci3z46gcjgutv4jid3ir6xn6a5adq3tx6v2e25augq
- valory/transaction_settlement_abci:0.1.0:bafybeibv3tycpdhphlblu62zpcbjsj7hnwkutexxqagorkelhjlt4t4fii
- valory/tx_settlement_multiplexer_abci:0.1.0:bafybeiglvalfzo744cvxvslx4vo42r4tcozn7hzsn3aa2q3hkm77t77xwe
- valory/tx_settlement_multiplexer_abci:0.1.0:bafybeighlmd4xj64qf3xtgbcxvqnipcnsvv47npkrlatngan2e6r23elhm
- valory/market_manager_abci:0.1.0:bafybeic67hypwetzltnuy3a6y3o2o332lxyvn34buq57gy4n6bfqpbpxjm
- valory/decision_maker_abci:0.1.0:bafybeigterfcylnzjzxpja6u56gvcq2grcgvia2qcj34yr2ksogss33wuu
- valory/trader_abci:0.1.0:bafybeifepfhwcrbinv22hlltrf2cfacqybzsdnm63knw73yc5yfoer3ks4
- valory/decision_maker_abci:0.1.0:bafybeiebddoshz7szs22sm7fn2cb4ywb6oa46ohc2naqcoznggb3nde43u
- valory/trader_abci:0.1.0:bafybeigkd4zkooaeng7ujroqpletfslja23fn6e6x4zuneictevpgeqw7y
- valory/staking_abci:0.1.0:bafybeihwyron2bv7ierrgxke7xofwjy7x6wtglg5vopon7i7lfdiivweaq
- valory/check_stop_trading_abci:0.1.0:bafybeifbiko6p3sqqg2q6qemmcig432s5djcsxm44j35ejittlpyr5f6z4
- valory/mech_interact_abci:0.1.0:bafybeidnmszufszq3ro4ebgrqzmhqgctrsc6sykeanfsbvotghvt2cgfsy
- valory/check_stop_trading_abci:0.1.0:bafybeiexmdtj3qfjnhh2sy3fa4hwxkvqogsy7u46liobzhgilzogeoezeu
- valory/mech_interact_abci:0.1.0:bafybeihhwzpa6x5ypth426tzd2zjsnys6jmjaab4zvk4edisetzktft754
- valory/chatui_abci:0.1.0:bafybeie2kmgihgk3rwpzelaa76ypvchsyg2vy3me4vxlbjttaq4frs3ipa
- valory/agent_performance_summary_abci:0.1.0:bafybeigmmvpncem6i6t57nwjqzajrbnf6rnqgp43mlo6jf6uziq6lrhlca
- valory/funds_manager:0.1.0:bafybeibne4vkmbper3ryn7q6kt7lclbyylgorziscyn6msr5qt46aihv4m
Expand Down
1 change: 1 addition & 0 deletions packages/valory/contracts/balance_tracker_fixed_price_native/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# BalanceTrackerFixedPriceNative contract
20 changes: 20 additions & 0 deletions packages/valory/contracts/balance_tracker_fixed_price_native/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# -*- coding: utf-8 -*-
# ------------------------------------------------------------------------------
#
# Copyright 2026 Valory AG
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# ------------------------------------------------------------------------------

"""This module contains the BalanceTrackerFixedPriceNative contract."""
Loading
Loading