Skip to content

Fix general bugs#7

Merged
van-sprundel merged 11 commits into
masterfrom
general-bugs
Dec 27, 2025
Merged

Fix general bugs#7
van-sprundel merged 11 commits into
masterfrom
general-bugs

Conversation

@van-sprundel

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @van-sprundel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on addressing several general bugs and enhancing the robustness and user experience of the application. It includes updates to dependency management, refines episode information parsing, improves error handling for critical system operations, and introduces measures to prevent conflicts in temporary file management. Additionally, it strengthens the Torznab client's ability to handle magnet links and resolves minor UI inconsistencies related to cursor positioning and settings navigation.

Highlights

  • Dependency Updates: Added unicode-width and uuid crates to Cargo.toml and Cargo.lock to support new functionalities.
  • Improved Episode Parsing: The parse_episode_info function now correctly handles two-digit season numbers (e.g., S10E02) and includes logic to prevent misinterpreting years as season/episode combinations.
  • Robust Error Handling for System Time: Added error handling for SystemTime::now().duration_since(UNIX_EPOCH) calls in WatchHistory to prevent panics if system time is unavailable or invalid.
  • Unique Streaming Session Directories: Each streaming session now creates a unique temporary subdirectory using a UUID, preventing potential file conflicts between concurrent sessions.
  • Torznab Client Magnet Link Handling: The Torznab client now ignores empty magneturl and infohash attributes in XML responses, ensuring that invalid magnet links are not generated or prioritized over valid download links.
  • TUI Settings Navigation Fix: Reset the settings section and field index when navigating to the settings view in the TUI, ensuring a consistent starting state.
  • TUI Cursor Positioning: Fixed cursor positioning in the TUI search input by using unicode_width to correctly account for multi-byte characters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a variety of bug fixes and improvements across the application. The changes to handle unique streaming session directories, validate configuration on save, and correctly parse episode information from filenames are all excellent enhancements. The improved error handling for system time and empty Torznab attributes adds robustness. The UI also sees nice improvements with correct cursor positioning and consistent state for the settings view.

I have one suggestion regarding performance and robustness in the regex parsing logic. Overall, this is a solid set of fixes.

Comment thread src/extensions/mod.rs Outdated
@van-sprundel
van-sprundel merged commit cd89bd6 into master Dec 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant