Require word boundary in alias reminder prefix match - #2
Open
shinenelson wants to merge 1 commit into
Open
Conversation
The alias reminder compared the typed command against an alias's expansion using a plain string prefix check, so any typed command that happened to start with the expansion text matched — even when the remaining characters weren't a separate argument. An alias like ...='cd ../../' then falsely fired for cd ../../another/path, a path the alias can't reach, since using it would pass "../../" and "another/path" as two separate arguments to cd instead of one concatenated path. Require the match to land on a word boundary (end of string or a following space) in bash, zsh, fish, and nushell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alias reminder compared the typed command against an alias's
expansion using a plain string prefix check, so any typed command
that happened to start with the expansion text matched — even when
the remaining characters weren't a separate argument. An alias like
...='cd ../../' then falsely fired for cd ../../another/path, a path
the alias can't reach, since using it would pass "../../" and
"another/path" as two separate arguments to cd instead of one
concatenated path. Require the match to land on a word boundary
(end of string or a following space) in bash, zsh, fish, and
nushell.