This repository was archived by the owner on Mar 29, 2026. It is now read-only.
fix: handle non-SELECT read queries (SHOW, DESCRIBE, EXPLAIN) in run_sql tool#1129
Open
nagasumanthila wants to merge 1 commit into
Open
fix: handle non-SELECT read queries (SHOW, DESCRIBE, EXPLAIN) in run_sql tool#1129nagasumanthila wants to merge 1 commit into
nagasumanthila wants to merge 1 commit into
Conversation
…sql tool- Added READ_QUERY_TYPES - Added comments explaining why these queries are treated as read queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The run_sql tool currently determines query type using only the first SQL keyword and treats only "SELECT" queries as returning data. However, several SQL commands such as SHOW, DESCRIBE / DESC, and EXPLAIN also return tabular result sets. These are incorrectly treated as data manipulation queries, resulting in misleading responses like "Query executed successfully. X row(s) affected."
Solution
Result