Google OAuth fixes#107
Open
danpalmer wants to merge 4 commits into
Open
Conversation
Member
|
Just an FYI I'm going to be doing an Imperial code sprint next week to go through all the issues and PRs |
Member
|
@rafiki270 do we need to pull these changes into the new changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using a fork from @noli-ai that has been deleted or made private. This contained several fixes. In the interests of giving visibility to those fixes I'm opening this PR to address an issue that another committer found. This is not my work, but I am depending on these fixes in order to use Google authentication with Imperial.
Unfortunately I don't know much about the details of the changes – the commit descriptions are the only documentation I have available.
If there are small changes necessary to get this merged I'm happy to make them!