Combining with manual auth middleware#85
Open
JeronimoPaganini wants to merge 1 commit into
Open
Conversation
The reason why I've proposed these updates is case:
1) Would be awesome if we have Imperial OAuth + manual authentication way
2) Also, if we gonna use just protectedMiddlewares group we shouldn't split out the oAuth and manual authentication middlewares.
Example:
```swift
let protectedMiddlewares: [Middleware] = [
ImperialMiddleware(redirect: "/login/"),
UserModel.redirectMiddleware(path: "/login/"),
UserModel.guardMiddleware(),
ActiveUserMiddleware()
]
let authRequired = app.routes.grouped(protectedMiddlewares)
authRequired.get("myProfile", use: profileController.index)
```
where `UserModel.redirectMiddleware` is `Authenticatable.redirectMiddleware`
And at this point, if a user has been manually authorized, ImperialMiddleware anyway will decline access to this route since the user hasn't accessToken.
If we use my proposed small upade, it might be used like:
```swift
let protectedMiddlewares: [Middleware] = [
AuthMiddleware(redirect: "/login/",
onErrorMiddleware: UserModel.redirectMiddleware(path: "/login/")),
UserModel.guardMiddleware(),
ActiveUserMiddleware()
]
let authRequired = app.routes.grouped(protectedMiddlewares)
authRequired.get("myProfile", use: profileController.index)
```
where onErrorMiddleware is optional and works only in the case if accessToken doesn't exist.
If I've made something overhead and we have a better solution for the case, please let me know :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason why I've proposed these updates is case:
Example:
where
UserModel.redirectMiddlewareisAuthenticatable.redirectMiddlewareAnd at this point, if a user has been manually authorized, ImperialMiddleware anyway will decline access to this route since the user hasn't accessToken.
If we use my proposed small upade, it might be used like:
where onErrorMiddleware is optional and works only in the case if accessToken doesn't exist.
If I've made something overhead and we have a better solution for the case, please let me know :)