Skip to content

Fix compilation issues - #60

Merged
fpseverino merged 5 commits into
mainfrom
reply-to
Oct 9, 2025
Merged

Fix compilation issues#60
fpseverino merged 5 commits into
mainfrom
reply-to

Conversation

@fpseverino

Copy link
Copy Markdown
Member

Resolves #59, closes #49

@ptoffy ptoffy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally be happier if we credited the original PR and merged that instead

@fpseverino

Copy link
Copy Markdown
Member Author

I'd personally be happier if we credited the original PR and merged that instead

There are conflicts to solve in the original PR, and I'm not a maintainer of this repo

@fpseverino

Copy link
Copy Markdown
Member Author

The API breakage is failing because it searches for the main branch, but in this repo the default branch is called master. Again, not being a maintainer of this repo I can't rename the branch

@fpseverino fpseverino changed the title Add encoding for replyTo field in MailgunTemplateMessage Fix compilation issues Oct 9, 2025
@fpseverino

Copy link
Copy Markdown
Member Author

I'd personally be happier if we credited the original PR and merged that instead

In the end I became a maintainer and merged the original PR 馃槄

@fpseverino
fpseverino merged commit b9c974f into main Oct 9, 2025
24 of 26 checks passed
@fpseverino
fpseverino deleted the reply-to branch October 9, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

replyTo still not encoded

2 participants