Skip to content

try out vapor run-unit-tests [stuck]#2

Draft
sliemeobn wants to merge 4 commits into
mainfrom
ci/vapor-ci
Draft

try out vapor run-unit-tests [stuck]#2
sliemeobn wants to merge 4 commits into
mainfrom
ci/vapor-ci

Conversation

@sliemeobn

Copy link
Copy Markdown
Collaborator

No description provided.

@sliemeobn sliemeobn mentioned this pull request Jul 5, 2024
@MahdiBM MahdiBM marked this pull request as ready for review July 5, 2024 08:15
@MahdiBM

MahdiBM commented Jul 5, 2024

Copy link
Copy Markdown

[It doesn't run for draft PRs, because of the types: [opened, reopened, synchronize, ready_for_review] line 🙂]

@MahdiBM

MahdiBM commented Jul 5, 2024

Copy link
Copy Markdown

ok these failures are not the ones i expected 😅 some kind of compiler bug?!

@sliemeobn

Copy link
Copy Markdown
Collaborator Author

well.... that went well ; )
seems like hitting a lot of compiler bugs. I think it's the variadic generics that are not quite 100%.
there are a few swift compiler issues on github open for it too - just a guess though.

Comment thread .github/workflows/ci.yaml
Co-authored-by: Mahdi Bahrami <github@mahdibm.com>
@MahdiBM

MahdiBM commented Jul 5, 2024

Copy link
Copy Markdown

hmm that helped ...
The API breakage check is disable-able but not sure what to do about Swift 5.10 one. It appears the bug only happens on Ubuntu Noble now?

@MahdiBM

MahdiBM commented Jul 5, 2024

Copy link
Copy Markdown

Nope, this is a dead-end with the Swift 5.10 Noble bug.

@MahdiBM

MahdiBM commented Jul 5, 2024

Copy link
Copy Markdown

Feel free to close the PR. We can try updating in some months or something I guess.
Or get Gwynne to add a config option to not use 5.10 noble.

@sliemeobn

Copy link
Copy Markdown
Collaborator Author

thanks for your efforts, I'll park the PR for now, maybe somebody fixes the 5.10 compiler issues eventually.
it's good to see it work on 6.0, so at least we have that going.

@sliemeobn sliemeobn changed the title try out vapor run-unit-tests try out vapor run-unit-tests [stuck] Jul 5, 2024
@sliemeobn sliemeobn marked this pull request as draft July 5, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants