-
-
Notifications
You must be signed in to change notification settings - Fork 56
Remove ConsoleKit from ConsoleLogger
#223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fpseverino
merged 8 commits into
vapor:consolekit-5
from
fpseverino:remove-consolekit-dep
Nov 21, 2025
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d4a2ba1
Remove `ConsoleKit` from `ConsoleLogger`
fpseverino 0936fe8
Make the linter happy
fpseverino 9c88bd9
Update thresholds
fpseverino 7c65f5f
Remove warning from tests
fpseverino 4bf6892
Enable testing via `ConsoleLoggerPrinter` protocol
fpseverino a7b351f
Make `ConsoleLoggerPrinter` public
fpseverino daa9676
Fix DocC
fpseverino 1f7e173
Fix DocC
fpseverino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
Benchmarks/Thresholds/ConsoleLoggerBenchmarks.LoggerFragmentBuilder.p90.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "mallocCountTotal" : 52, | ||
| "peakMemoryResident" : 14278655 | ||
| "mallocCountTotal" : 38, | ||
| "peakMemoryResident" : 11042816 | ||
| } |
4 changes: 2 additions & 2 deletions
4
Benchmarks/Thresholds/ConsoleLoggerBenchmarks.Logging.p90.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| { | ||
| "mallocCountTotal" : 48, | ||
| "peakMemoryResident" : 13279231 | ||
| "mallocCountTotal" : 30, | ||
| "peakMemoryResident" : 11108352 | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #if canImport(Darwin) | ||
| import Darwin.C | ||
| #elseif canImport(Glibc) | ||
| @preconcurrency import Glibc | ||
| #elseif canImport(Musl) | ||
| @preconcurrency import Musl | ||
| #elseif canImport(Android) | ||
| @preconcurrency import Android | ||
| #elseif os(WASI) | ||
| import WASILibc | ||
| #elseif os(Windows) | ||
| import CRT | ||
| #endif | ||
|
|
||
| enum ANSIColor: String { | ||
| case red = "\u{001B}[31m" | ||
| case green = "\u{001B}[32m" | ||
| case yellow = "\u{001B}[33m" | ||
| case cyan = "\u{001B}[36m" | ||
| case brightRed = "\u{001B}[91m" | ||
| } | ||
|
|
||
| extension String { | ||
| func colored(_ color: ANSIColor?) -> String { | ||
| guard supportsANSICommands, let color else { return self } | ||
| return color.rawValue + self + "\u{001B}[0m" | ||
| } | ||
| } | ||
|
|
||
| private var supportsANSICommands: Bool { | ||
| #if Xcode | ||
| // Xcode output does not support ANSI commands | ||
| return false | ||
| #else | ||
| // If STDOUT is not an interactive terminal then omit ANSI commands | ||
| return isatty(STDOUT_FILENO) > 0 | ||
| #endif | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
Sources/ConsoleLogger/LoggerFragments/DefaultLoggerFragments.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import ConsoleKit | ||
| import Logging | ||
|
|
||
| /// The type of the default ``LoggerFragment``. | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.