New Design - #1133
Conversation
ptoffy
left a comment
There was a problem hiding this comment.
Nice! Adding them as I see them
- heading margin from the divider should be the same as the one above the divider:

- divider width should be consistent

- should we make boxes border radii consistent? (we definitely should for multi-line vs single-line code boxes)

- we might want some fade effects on text hover in the left sidebar and toc like we have in the navbar
- multiline codeblocks need padding resizing on top, bottom and left
- we probably want copy-code buttons
- what's going on here?

|
Looking good! Everything Paul said, but especially:
Section, language and version selection is a bit weird on mobile IMHO The Welcome page doesn't have the heading image and/or title in some languages, is it something we translators have to fix? |
A lot of these are to be fixed in the design repo as that's where the shared styles live |
Yep planning to add this to the design repo so they all get it across all the sites |
Anything specific @fpseverino ? |
The button to open the section selection panel (circled in red) is a bit small and easy to miss (I have a big phone), and the language and version selection being in the same menu (circled in green) where the links to the home and blog are is a bit weird IMHO, it's not where I would intuitively think they are. Take everything I say with a pinch of salt, I'm not a designer (pretty sure in fact I butchered the terminology) |
That's a fair point. I've bumped the size As for the placement of the other options, the main issue with putting them in the left hand menu is that they'll be pushed down and not visible for most of the time. We can iterate further though! |

Now we control the doc generation stack we can (finally!) adopt the new design on the docs site.