Skip to content

New Design - #1133

Merged
0xTim merged 24 commits into
mainfrom
new-design
Jun 10, 2026
Merged

New Design#1133
0xTim merged 24 commits into
mainfrom
new-design

Conversation

@0xTim

@0xTim 0xTim commented Jun 10, 2026

Copy link
Copy Markdown
Member

Now we control the doc generation stack we can (finally!) adopt the new design on the docs site.

Screenshot 2026-06-09 at 19 56 36

@0xTim
0xTim requested review from a team and gwynne as code owners June 10, 2026 03:10
@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Jun 10, 2026
@github-actions
github-actions Bot temporarily deployed to PR-1133 June 10, 2026 03:14 Destroyed
@github-actions
github-actions Bot temporarily deployed to PR-1133 June 10, 2026 10:01 Destroyed

@ptoffy ptoffy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Adding them as I see them

  • heading margin from the divider should be the same as the one above the divider:
    Image
  • divider width should be consistent
    Image
  • should we make boxes border radii consistent? (we definitely should for multi-line vs single-line code boxes)
    Image
  • we might want some fade effects on text hover in the left sidebar and toc like we have in the navbar
  • multiline codeblocks need padding resizing on top, bottom and left
  • we probably want copy-code buttons
  • what's going on here?
    Image

Comment thread docs/4.0/index.md
@fpseverino

Copy link
Copy Markdown
Member

Looking good!

Everything Paul said, but especially:

we probably want copy-code buttons

Section, language and version selection is a bit weird on mobile IMHO

The Welcome page doesn't have the heading image and/or title in some languages, is it something we translators have to fix?

@0xTim

0xTim commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Nice! Adding them as I see them

A lot of these are to be fixed in the design repo as that's where the shared styles live

@0xTim

0xTim commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Everything Paul said, but especially:

we probably want copy-code buttons

Yep planning to add this to the design repo so they all get it across all the sites

@0xTim

0xTim commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Section, language and version selection is a bit weird on mobile IMHO

Anything specific @fpseverino ?

@fpseverino

Copy link
Copy Markdown
Member

Section, language and version selection is a bit weird on mobile IMHO

Anything specific @fpseverino ?

image

The button to open the section selection panel (circled in red) is a bit small and easy to miss (I have a big phone), and the language and version selection being in the same menu (circled in green) where the links to the home and blog are is a bit weird IMHO, it's not where I would intuitively think they are.

Take everything I say with a pinch of salt, I'm not a designer (pretty sure in fact I butchered the terminology)

@github-actions
github-actions Bot temporarily deployed to PR-1133 June 10, 2026 18:13 Destroyed
@github-actions
github-actions Bot temporarily deployed to PR-1133 June 10, 2026 18:26 Destroyed
@0xTim

0xTim commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

The button to open the section selection panel (circled in red) is a bit small and easy to miss

That's a fair point. I've bumped the size

As for the placement of the other options, the main issue with putting them in the left hand menu is that they'll be pushed down and not visible for most of the time. We can iterate further though!

@0xTim
0xTim merged commit d2bf8ec into main Jun 10, 2026
3 checks passed
@0xTim
0xTim deleted the new-design branch June 10, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants