Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #541

wants to merge 1 commit into from

Conversation

Joannis
Copy link
Member

@Joannis Joannis commented Mar 11, 2025

The readme has a broken example snippet for running queries which is extremely confusing if you try to use it.
The result of this omission results in trying to run a query which leads users to use a String overload rather than the PostgresQuery overload which is not only SQL injection vulnerable but also returns an EventLoopFuture<PostgresResult>

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.37%. Comparing base (5d817be) to head (24a6809).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   61.39%   61.37%   -0.02%     
==========================================
  Files         125      125              
  Lines       10149    10149              
==========================================
- Hits         6231     6229       -2     
- Misses       3918     3920       +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants