Fix benchmarks take two - #140
Merged
Merged
Conversation
ptoffy
marked this pull request as ready for review
September 1, 2025 10:19
ptoffy
added a commit
that referenced
this pull request
Nov 14, 2025
* Change comma * Fix benchmarks take two (#140) * Fix benchmarks take two * Add throughput thresholds * Wip * Make `Router` Swift 6 ready (#135) * First attempt at Swift 6 router * Make router immutable in benchmarks * Update benchmarks manifest * Re-add swift settings * Make options immutable * Update thresholds * Update thresholds * Update benchmarks * Adjust thresholds * Adjust thresholds * Use appropriate property * Create RouterBuilder * Update benchmarks * Address review and sprinke some `@inlinable` * Add back package setting * Update benchmarks * Update benchmark thresholds * Adjust threshold * Implement partial matching of routes (#142) * Implement partial matching * Attempt at making it fast * Cleanup * Undo * Partial Matching 2 (#143) * Different approach to partial matching * Nits * Avoid a copy * Minor improvements * Nit * Update Sources/RoutingKit/PathComponent.swift Co-authored-by: Gwynne Raskind <gwynne@vapor.codes> * Update Sources/RoutingKit/TrieRouter/TrieRouterNode.swift Co-authored-by: Gwynne Raskind <gwynne@vapor.codes> * Nits * Nit --------- Co-authored-by: Gwynne Raskind <gwynne@vapor.codes> * Add some docs * Address review and add specificity sorting * Add specificity comment * Add precondition failure for invalid partial * Don't run 6.2 test syntax on <6.2 * Nits * Apply suggestions from code review Co-authored-by: Gwynne Raskind <gwynne@vapor.codes> * Don't run exit test on Android --------- Co-authored-by: Gwynne Raskind <gwynne@vapor.codes>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.