Skip to content
This repository was archived by the owner on Nov 16, 2020. It is now read-only.

Support getting generic and type-safe process environment variables via LosslessStringConvertible protocol#37

Open
wlisac wants to merge 1 commit intovapor:1from
wlisac:generic-process-environment-variables
Open

Support getting generic and type-safe process environment variables via LosslessStringConvertible protocol#37
wlisac wants to merge 1 commit intovapor:1from
wlisac:generic-process-environment-variables

Conversation

@wlisac
Copy link
Copy Markdown

@wlisac wlisac commented Mar 5, 2019

No description provided.

@gperdomor
Copy link
Copy Markdown

LGTM! 👍

@tanner0101 tanner0101 added the enhancement New feature or request label Mar 5, 2019
Copy link
Copy Markdown
Member

@tanner0101 tanner0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition LGTM, thanks! We just need to make a slight change to circle CI. Would you mind doing that?

In https://github.com/vapor/service/blob/1/circle.yml

  • linux-fluent-postgresql needs to checkout branch 1 instead of master
  • linux-vapor needs to checkout branch 3 instead of master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants