Skip to content

Resolve issues breaking Swift Wasm builds for sql-kit #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwynne merged 6 commits into from
Jul 28, 2025
Merged

Resolve issues breaking Swift Wasm builds for sql-kit #190

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
84d0abd
fix: Resolve issues breaking wasm build in sql-kit. Needed to require…
scottmarchant Jun 25, 2025
75e28b6
fix: Don't require a bump in the minimum swift-nio version.
scottmarchant Jun 25, 2025
f0c7fa6
refactor: Only elide the full NIO dependency if WASI is the target pl…
scottmarchant Jul 14, 2025
26ec6d1
chore: Update minimum required version of swift-nio to 2.84.0, which …
scottmarchant Jul 14, 2025
b7622d7
ci: Adds wasm build to CI.
scottmarchant Jun 25, 2025
f0c57cb
chore: Clean out backwards compatibility provisions for NIO implicit …
scottmarchant Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ let package = Package(
dependencies: [
.package(url: "https://github.com/apple/swift-collections.git", from: "1.1.0"),
.package(url: "https://github.com/apple/swift-log.git", from: "1.5.4"),
// NOTE: Compiling to wasm requires specific versions of swift-nio.
Comment thread
scottmarchant marked this conversation as resolved.
Outdated
// This older version is left as-is to avoid placing restrictions
// on other targets. But to compile for wasm, make sure you have
// a version of swift-nio with a passing build for the NIOCore module.
.package(url: "https://github.com/apple/swift-nio.git", from: "2.65.0"),
],
targets: [
Expand All @@ -24,7 +28,6 @@ let package = Package(
dependencies: [
.product(name: "Collections", package: "swift-collections"),
.product(name: "Logging", package: "swift-log"),
.product(name: "NIO", package: "swift-nio"),
Comment thread
scottmarchant marked this conversation as resolved.
.product(name: "NIOCore", package: "swift-nio"),
],
swiftSettings: swiftSettings
Expand Down
4 changes: 2 additions & 2 deletions Sources/SQLKit/Exports.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
@_documentation(visibility: internal) @_exported import protocol NIO.EventLoop
@_documentation(visibility: internal) @_exported import class NIO.EventLoopFuture
Comment thread
scottmarchant marked this conversation as resolved.
@_documentation(visibility: internal) @_exported import protocol NIOCore.EventLoop
@_documentation(visibility: internal) @_exported import class NIOCore.EventLoopFuture
Comment thread
scottmarchant marked this conversation as resolved.
@_documentation(visibility: internal) @_exported import struct Logging.Logger