Conversation
fpseverino
requested changes
Jul 6, 2026
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
0xTim
requested changes
Jul 21, 2026
0xTim
left a comment
0xTim
left a comment
Member
There was a problem hiding this comment.
Ok I think this looks mostly good, a couple of comments
We can't merge this until release however, so I think once we're happy with the PR, lets close it so vapor5 can be the branch we use, unless we want to keep it open as a draft PR until release. Future changes should be PRed into this branch
Comment on lines
+25
to
+26
| try await migrator.setupIfNeeded().get() | ||
| try await migrator.prepareBatch().get() |
Member
There was a problem hiding this comment.
Do we need to wrap this to catch errors and run revert if they fail?
Member
Author
|
Superseded by #176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the template to use the first alpha of Vapor 5. Leaf needs some serious changes to make it work so I've commented it out for now. I've also had to add some extensions to use Fluent with DI, those will likely be added to vapor/fluent