Fix error raised when requiring pundit/rspec before active support#857
Merged
Burgestrand merged 2 commits intomainfrom May 6, 2025
Merged
Fix error raised when requiring pundit/rspec before active support#857Burgestrand merged 2 commits intomainfrom
Burgestrand merged 2 commits intomainfrom
Conversation
Regression from #837. See #837 (comment) In brief, this happens if you require `pundit/rspec` before `active_support`, since `pundit/rspec` will require in array conversions. Additionally this will make sure all of Pundit is required alongside `pundit/rspec`, which I believe generally makes sense since you want Pundit in order to be able to test Pundit.
Member
Author
|
Fixed #856 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression from #837
To do
PS: Thank you for contributing to Pundit ❤️