Skip to content

Comments

Add rubocop config file back to gem release files#866

Merged
Burgestrand merged 2 commits intomainfrom
kbs/add-rubocop-back
Sep 24, 2025
Merged

Add rubocop config file back to gem release files#866
Burgestrand merged 2 commits intomainfrom
kbs/add-rubocop-back

Conversation

@Burgestrand
Copy link
Member

Closes #865

We changed which files are included in the gem recently, this was done to modernize our gemspec along with what bundle gem generated.

bundle gem mygem --exe --coc --changelog --github-username=burgestrand --mit --test=rspec --ci=github --linter=standard

spec.files = Dir.chdir(__dir__) do
    `git ls-files -z`.split("\x0").reject do |f|
      (File.expand_path(f) == __FILE__) ||
        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor Gemfile])
    end
  end

That change accidentally removed a config file we point rubocop to in our README.

To do

  • I have read the contributing guidelines.
  • I have added relevant tests.
  • I have adjusted relevant documentation.
  • I have made sure the individual commits are meaningful.
  • I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

Closes #865

We changed which files are included in the gem recently, this was done to modernize our gemspec along with what `bundle gem` generated.

`bundle gem mygem --exe --coc --changelog --github-username=burgestrand --mit --test=rspec --ci=github --linter=standard`

```ruby
spec.files = Dir.chdir(__dir__) do
    `git ls-files -z`.split("\x0").reject do |f|
      (File.expand_path(f) == __FILE__) ||
        f.start_with?(*%w[bin/ test/ spec/ features/ .git .github appveyor Gemfile])
    end
  end
```

That change accidentally removed a config file we point rubocop to in our README.
@Burgestrand Burgestrand merged commit 674abac into main Sep 24, 2025
17 checks passed
@Burgestrand Burgestrand deleted the kbs/add-rubocop-back branch September 24, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pundit 2.5.1 distribution missing file config/rubocop-rspec.yml

1 participant