feat(lite): add ability to forget a PIF from the network table by amouillard-vates · Pull Request #10239 · vatesfr/xen-orchestra

amouillard-vates · 2026-08-06T07:50:32Z

Description

Adds ability to forget a PIF from the host > network > PIFs table / sidepanel on xo-lite
("delete" has been renamed "forget")

Checklist

Commit
- Title follows commit conventions
- Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
- If bug fix, add Introduced by
Changelog
- If visible by XOA users, add changelog entry
- Update "Packages to release" in CHANGELOG.unreleased.md
PR
- If UI changes, add screenshots
- If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

develop skills of junior reviewers

limit the workload for senior reviewers

limit the number of unnecessary changes by the author

The author creates a PR.
Review process:
1. The author assigns the junior reviewer.
2. The junior reviewer conducts their review:
  - Resolves their comments if they are addressed.
  - Adds comments if necessary or approves the PR.
3. The junior reviewer assigns the senior reviewer.
4. The senior reviewer conducts their review:
  - If there are no unresolved comments on the PR → merge.
  - Otherwise, we continue with 3.
The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

The author can request a review at any time, even if the PR is still a Draft.
In theory, there should not be more than one reviewer at a time.
The author should not make any changes:
- When a reviewer is assigned.
- Between the junior and senior reviews.
If the PR relates to a change in the openAPI specification, a member of the DevOps team must also participate in the review.

MarieGarde · 2026-08-10T06:54:54Z

@@ -0,0 +1,11 @@
+import { useOverlay } from '@core/packages/overlay/use-overlay.ts'


Same remark as for the modal

MathieuRA

There is something strange about your screenshot.
In the table, it shows "status: disconnected," but in the side panel, it shows a "connected" status.

I have only reviewed the pif-operation.ts, so, that maybe a normal behavior, but at first glance, it looks like a bug.

MathieuRA · 2026-08-24T07:44:03Z

+    forget: (pifs: MaybeArray<XenApiPif>) =>
+      Promise.all(
+        toArray(pifs).map(async pif => {
+          if (pif.VLAN_master_of !== 'OpaqueRef:NULL') {


use OPAQUE_REF.EMPTY from vates/types/common.mts instead

The table status column was cut in the screenshot but is displaying "Disconnected from physical device", which is the physical interface status in the sidepanel. Both statuses are combined in one column.

MarieGarde · 2026-08-28T14:11:52Z

Remember to explain in the PR description why the card says "delete PIF" while the PR uses "forget PIF" throughout.

MarieGarde · 2026-08-28T14:17:21Z

@@ -0,0 +1,48 @@
+<template>
+  <UiModal accent="warning" icon="status:warning-picto" @confirm="emit('confirm')" @dismiss="emit('cancel')">


Suggested change

<UiModal accent="warning" icon="status:warning-picto" @confirm="emit('confirm')" @dismiss="emit('cancel')">

<UiModal accent="danger" icon="status:warning-picto" @confirm="emit('confirm')" @dismiss="emit('cancel')">

Since the button is red? I'm not sure we're keeping that logic.

I think we can

MarieGarde · 2026-08-28T14:31:39Z

Add in changelog unreleased :

@xen-orchestra/web minor
@xen-orchestra/web-core minor

MarieGarde · 2026-08-28T14:42:05Z

@@ -0,0 +1,52 @@
+import type { XenApiPif } from '@/libs/xen-api/xen-api.types.ts'


File name : use-pif-forget.composable.ts

To stay consistent with the project's conventions (cf. use-vif-connection.composable, use-sr-delete.composable)

MarieGarde · 2026-08-28T14:42:15Z

+import type { MaybeRefOrGetter } from 'vue'
+import { useI18n } from 'vue-i18n'
+
+export function usePifForgetModal(rawPifs: MaybeRefOrGetter<XenApiPif[]>) {


Suggested change

export function usePifForgetModal(rawPifs: MaybeRefOrGetter<XenApiPif[]>) {

export function usePifForget(rawPifs: MaybeRefOrGetter<XenApiPif[]>) {

J0ris-K · 2026-10-01T15:27:57Z

+
+  const { run, canRun, isRunning, errorMessage } = usePifForgetJob(pifs)
+
+  const { open: openForgetModal } = useOverlay({


Suggested change

const { open: openForgetModal } = useOverlay({

const { open } = useOverlay({

J0ris-K · 2026-10-01T15:28:09Z

+    },
+  })
+
+  function openModal() {


Suggested change

function openModal() {

function forgetPifs() {

J0ris-K · 2026-10-01T15:28:20Z

+  function openModal() {
+    const count = pifs.value.length
+
+    return openForgetModal({


Suggested change

return openForgetModal({

return open({

J0ris-K · 2026-10-01T15:29:15Z

+
+  const selectedPifId = useRouteQuery('id')
+
+  const { run, canRun, isRunning, errorMessage } = usePifForgetJob(pifs)


Suggested change

const { run, canRun, isRunning, errorMessage } = usePifForgetJob(pifs)

const {

run: runForget,

canRun: canForgetPifs,

isRunning: isForgettingPifs,

errorMessage: forgetPifsErrorMessage,

} = usePifForgetJob(pifs)

J0ris-K · 2026-10-01T15:29:31Z

+      events: {
+        onConfirm: async () => {
+          try {
+            await run()


Suggested change

await run()

await runForget()

J0ris-K · 2026-10-01T15:58:50Z

  "confirm-cancel?": "Êtes-vous sûr de vouloir annuler ?",
  "confirm-delete": "Vous êtes sur le point de supprimer {name}",
  "confirm-disconnect": "Vous êtes sur le point de déconnecter {0}",
+  "confirm-forget": "Vous êtes sur le point d'oublier {0}",


Suggested change

"confirm-forget": "Vous êtes sur le point d'oublier {0}",

"confirm-forget": "Vous êtes sur le point d'oublier {name}",

J0ris-K · 2026-10-01T15:59:02Z

  "confirm-cancel?": "Are you sure you want to cancel?",
  "confirm-delete": "You're about to delete {name}",
  "confirm-disconnect": "You're about to disconnect {0}",
+  "confirm-forget": "You're about to forget {0}",


Suggested change

"confirm-forget": "You're about to forget {0}",

"confirm-forget": "You're about to forget {name}",

J0ris-K · 2026-10-01T16:00:41Z

+        :busy="isForgettingPif"
+        :disabled="!canForgetPif"
+        :tooltip="!canForgetPif && forgetPifErrorMessage"
+        @click="openPifForgetModal()"


Suggested change

:busy="isForgettingPif"

:disabled="!canForgetPif"

:tooltip="!canForgetPif && forgetPifErrorMessage"

@click="openPifForgetModal()"

:busy="isForgettingPifs"

:disabled="!canForgetPifs"

:tooltip="!canForgetPifs && forgetPifsErrorMessage"

@click="forgetPifs()"

J0ris-K · 2026-10-01T16:16:52Z

You can change screenshots too

amouillard-vates self-assigned this Aug 6, 2026

amouillard-vates added the XO Lite label Aug 6, 2026

amouillard-vates requested review from MarieGarde and MathieuRA August 6, 2026 07:52

MathieuRA reviewed Aug 6, 2026

View reviewed changes

Comment thread @xen-orchestra/lite/src/libs/xen-api/operations/pif-operations.ts Outdated